2687cd116a
<rdar://problem/11051056> Found a race condition when sending async packets in the ProcessGDBRemote. A little background: GDB remote clients can only send one packet at a time. You must send a packet and wait for a response. So when we continue, we obviously can't hold up the calling thread waiting for the process to stop again, so we have an async thread in the ProcessGDBRemote whose only job is to run packets that control the inferior process. When you send a continue packet, the only packet you can send is an interrupt packet (which consists of sending a CTRL+C (or a '\x03' byte)). This then stops the inferior and we can send the async packet, and then resume the target. There was a race condition that often happened during stepping where we are doing a source level single step which consists of many instruction steps and a few runs here and there when we step into a function. So the flow looks like: inst single step inst single step inst single step inst single step inst single step step BP and run inst single step inst single step inst single step Now if we got an async packet while the program is running we get something like: send --> continue send --> interrupt recv <-- interrupt stop reply packet send --> async packet recv <-- async response send --> continue again and wait for actual stop Problems arise when this was happening when single stepping a thread where we would get: send --> step thread 123 send --> interrupt send --> stop reply for thread 123 (from the step) Now we _might_ have an extra stop reply packet from the "interrupt" which we weren't checking for and we could end up with: send --> async packet (like memory read!) recv <-- async response (which is the interrupt stop reply packet) Now we have the read memroy reply sitting in our buffer and waiting to be used as the reply for the next packet... To further complicate things, the single step should have exited the async thread since the run control is finished, but now it will continue if it was interrupted. The fixes I checked in to two major things: - watch for the extra stop reply if we need to - make sure we exit from the async thread run loop when the previous run control (like the instruction level single step) is finished. Needless to say this makes very fast stepping in Xcode much more reliable. llvm-svn: 153629
58 lines
2.0 KiB
C++
58 lines
2.0 KiB
C++
//===-- ProcessGDBRemoteLog.h -----------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_ProcessGDBRemoteLog_h_
|
|
#define liblldb_ProcessGDBRemoteLog_h_
|
|
|
|
// C Includes
|
|
// C++ Includes
|
|
// Other libraries and framework includes
|
|
|
|
// Project includes
|
|
#include "lldb/Core/Log.h"
|
|
|
|
#define GDBR_LOG_VERBOSE (1u << 0)
|
|
#define GDBR_LOG_PROCESS (1u << 1)
|
|
#define GDBR_LOG_THREAD (1u << 2)
|
|
#define GDBR_LOG_PACKETS (1u << 3)
|
|
#define GDBR_LOG_MEMORY (1u << 4) // Log memory reads/writes calls
|
|
#define GDBR_LOG_MEMORY_DATA_SHORT (1u << 5) // Log short memory reads/writes bytes
|
|
#define GDBR_LOG_MEMORY_DATA_LONG (1u << 6) // Log all memory reads/writes bytes
|
|
#define GDBR_LOG_BREAKPOINTS (1u << 7)
|
|
#define GDBR_LOG_WATCHPOINTS (1u << 8)
|
|
#define GDBR_LOG_STEP (1u << 9)
|
|
#define GDBR_LOG_COMM (1u << 10)
|
|
#define GDBR_LOG_ASYNC (1u << 11)
|
|
#define GDBR_LOG_ALL (UINT32_MAX)
|
|
#define GDBR_LOG_DEFAULT GDBR_LOG_PACKETS
|
|
|
|
class ProcessGDBRemoteLog
|
|
{
|
|
public:
|
|
static lldb::LogSP
|
|
GetLogIfAllCategoriesSet(uint32_t mask = 0);
|
|
|
|
static lldb::LogSP
|
|
GetLogIfAnyCategoryIsSet (uint32_t mask);
|
|
|
|
static void
|
|
DisableLog (const char **categories, lldb_private::Stream *feedback_strm);
|
|
|
|
static lldb::LogSP
|
|
EnableLog (lldb::StreamSP &log_stream_sp, uint32_t log_options, const char **categories, lldb_private::Stream *feedback_strm);
|
|
|
|
static void
|
|
ListLogCategories (lldb_private::Stream *strm);
|
|
|
|
static void
|
|
LogIf (uint32_t mask, const char *format, ...);
|
|
};
|
|
|
|
#endif // liblldb_ProcessGDBRemoteLog_h_
|