18cfbc4b8e
The include order check would get notified of all include directives in a depth-first manner. This created the possibility of an include directive from a header file interfering with the sort order of a set of two distinct blocks from the top level cpp file, if that include directive was on just the right line. With this patch we bucket the include directives by the file in which they appear in and process one bucket at a time, so that directives from different files do not get mixed together into the same list. Reviewed By: alexfh Differential Revision: https://reviews.llvm.org/D23434 llvm-svn: 278546
43 lines
1.2 KiB
C++
43 lines
1.2 KiB
C++
// RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers
|
|
|
|
// CHECK-MESSAGES: [[@LINE+2]]:1: warning: #includes are not sorted properly
|
|
#include "j.h"
|
|
#include "gtest/foo.h"
|
|
#include "i.h"
|
|
#include <s.h>
|
|
#include "llvm/a.h"
|
|
#include "clang/b.h"
|
|
#include "clang-c/c.h" // hi
|
|
#include "llvm-c/d.h" // -c
|
|
|
|
// CHECK-FIXES: #include "j.h"
|
|
// CHECK-FIXES-NEXT: #include "i.h"
|
|
// CHECK-FIXES-NEXT: #include "clang-c/c.h" // hi
|
|
// CHECK-FIXES-NEXT: #include "clang/b.h"
|
|
// CHECK-FIXES-NEXT: #include "llvm-c/d.h" // -c
|
|
// CHECK-FIXES-NEXT: #include "llvm/a.h"
|
|
// CHECK-FIXES-NEXT: #include "gtest/foo.h"
|
|
// CHECK-FIXES-NEXT: #include <s.h>
|
|
|
|
#include "b.h"
|
|
#ifdef FOO
|
|
#include "a.h"
|
|
#endif
|
|
|
|
// CHECK-FIXES: #include "b.h"
|
|
// CHECK-FIXES-NEXT: #ifdef FOO
|
|
// CHECK-FIXES-NEXT: #include "a.h"
|
|
// CHECK-FIXES-NEXT: #endif
|
|
|
|
// CHECK-MESSAGES: [[@LINE+1]]:1: warning: #includes are not sorted properly
|
|
#include "b.h"
|
|
#include "a.h"
|
|
|
|
// CHECK-FIXES: #include "a.h"
|
|
// CHECK-FIXES-NEXT: #include "b.h"
|
|
|
|
// CHECK-MESSAGES-NOT: [[@LINE+1]]:1: warning: #includes are not sorted properly
|
|
#include "cross-file-c.h"
|
|
// This line number should correspond to the position of the #include in cross-file-c.h
|
|
#include "cross-file-a.h"
|