8c348b3338
Summary: This check will find out improper initialization of NSError objects. According to Apple developer document, we should always use factory method errorWithDomain:code:userInfo: to create new NSError objects instead of [NSError alloc] init]. Otherwise it will lead to a warning message during runtime in Xcode. The corresponding information about NSError creation: https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ErrorHandlingCocoa/CreateCustomizeNSError/CreateCustomizeNSError.html Reviewers: hokein, benhamilton Reviewed By: benhamilton Subscribers: klimek, mgorny, cfe-commits Differential Revision: https://reviews.llvm.org/D40528 llvm-svn: 319459
51 lines
1.6 KiB
C++
51 lines
1.6 KiB
C++
//===--- ObjCTidyModule.cpp - clang-tidy --------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../ClangTidyModule.h"
|
|
#include "../ClangTidyModuleRegistry.h"
|
|
#include "AvoidNSErrorInitCheck.h"
|
|
#include "AvoidSpinlockCheck.h"
|
|
#include "ForbiddenSubclassingCheck.h"
|
|
#include "PropertyDeclarationCheck.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace objc {
|
|
|
|
class ObjCModule : public ClangTidyModule {
|
|
public:
|
|
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
|
|
CheckFactories.registerCheck<AvoidNSErrorInitCheck>(
|
|
"objc-avoid-nserror-init");
|
|
CheckFactories.registerCheck<AvoidSpinlockCheck>(
|
|
"objc-avoid-spinlock");
|
|
CheckFactories.registerCheck<ForbiddenSubclassingCheck>(
|
|
"objc-forbidden-subclassing");
|
|
CheckFactories.registerCheck<PropertyDeclarationCheck>(
|
|
"objc-property-declaration");
|
|
}
|
|
};
|
|
|
|
// Register the ObjCTidyModule using this statically initialized variable.
|
|
static ClangTidyModuleRegistry::Add<ObjCModule> X(
|
|
"objc-module",
|
|
"Adds Objective-C lint checks.");
|
|
|
|
} // namespace objc
|
|
|
|
// This anchor is used to force the linker to link in the generated object file
|
|
// and thus register the ObjCModule.
|
|
volatile int ObjCModuleAnchorSource = 0;
|
|
|
|
} // namespace tidy
|
|
} // namespace clang
|