set_release_notes: support EDITOR with arguments

And conversely, quote the base directory in case it has spaces in the
path. The script is now Shellcheck-clean.
This commit is contained in:
Jordan Rose
2022-05-25 15:59:47 -07:00
parent 679042e728
commit a91efa9718

View File

@@ -7,7 +7,7 @@ BASE_DIR=$(git rev-parse --show-toplevel)
METADATA_ROOT="$BASE_DIR/fastlane/metadata"
# Open the editor for entering the changelog
"${VISUAL:-"${EDITOR:-vi}"}" "${METADATA_ROOT}/en-US/release_notes.txt"
${VISUAL:-${EDITOR:-vi}} "${METADATA_ROOT}/en-US/release_notes.txt"
${BASE_DIR}/Scripts/translation/push-metadata-source
${BASE_DIR}/Scripts/translation/pull-metadata-translations
"${BASE_DIR}"/Scripts/translation/push-metadata-source
"${BASE_DIR}"/Scripts/translation/pull-metadata-translations