mirrors/Signal-Server
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Server.git synced 2025-12-05 01:10:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefix AssertTrue validation methods with "is"

Browse Source
This commit is contained in:
Katherine
2025-11-04 16:25:12 -05:00
committed by GitHub
parent ce945ff245
commit f7eb6fab33
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
service/src/main/java/org/whispersystems/textsecuregcm/entities/IncomingMessageList.java
View File

@@ -48,7 +48,7 @@ public record IncomingMessageList(@NotNull
@AssertTrue
@Schema(hidden = true)
public boolean hasNoDuplicateRecipients() {
public boolean isNotDuplicateRecipients() {
final boolean valid = messages.stream()
.filter(Objects::nonNull)
.map(IncomingMessage::destinationDeviceId).distinct().count() == messages.size();

2
service/src/main/java/org/whispersystems/textsecuregcm/entities/LinkDeviceRequest.java
View File

@@ -43,7 +43,7 @@ public record LinkDeviceRequest(@Schema(requiredMode = Schema.RequiredMode.REQUI
@AssertTrue
@Schema(hidden = true)
public boolean hasExactlyOneMessageDeliveryChannel() {
public boolean isExactlyOneMessageDeliveryChannel() {
if (accountAttributes.getFetchesMessages()) {
return deviceActivationRequest().apnToken().isEmpty() && deviceActivationRequest().gcmToken().isEmpty();
} else {

2
service/src/main/java/org/whispersystems/textsecuregcm/entities/RegistrationRequest.java
View File

@@ -88,7 +88,7 @@ public record RegistrationRequest(@Schema(requiredMode = Schema.RequiredMode.NOT
@VisibleForTesting
@AssertTrue
@Schema(hidden = true)
boolean hasExactlyOneMessageDeliveryChannel() {
boolean isExactlyOneMessageDeliveryChannel() {
if (deviceActivationRequest == null || accountAttributes == null) {
return false;
}

2
service/src/main/java/org/whispersystems/textsecuregcm/limits/RateLimiterConfig.java
View File

@@ -17,7 +17,7 @@ public record RateLimiterConfig(int bucketSize, Duration permitRegenerationDurat
@AssertTrue
@Schema(hidden = true)
public boolean hasPositiveRegenerationRate() {
public boolean isPositiveRegenerationRate() {
try {
return permitRegenerationDuration.toNanos() > 0;
} catch (final ArithmeticException e) {

8
service/src/test/java/org/whispersystems/textsecuregcm/limits/RateLimiterConfigTest.java
View File

@@ -21,9 +21,9 @@ class RateLimiterConfigTest {
@Test
void isRegenerationRatePositive() {
assertTrue(new RateLimiterConfig(1, Duration.ofSeconds(1), false).hasPositiveRegenerationRate());
assertTrue(new RateLimiterConfig(1, Duration.ofNanos(1), false).hasPositiveRegenerationRate());
assertFalse(new RateLimiterConfig(1, Duration.ZERO, false).hasPositiveRegenerationRate());
assertFalse(new RateLimiterConfig(1, Duration.ofSeconds(-1), false).hasPositiveRegenerationRate());
assertTrue(new RateLimiterConfig(1, Duration.ofSeconds(1), false).isPositiveRegenerationRate());
assertTrue(new RateLimiterConfig(1, Duration.ofNanos(1), false).isPositiveRegenerationRate());
assertFalse(new RateLimiterConfig(1, Duration.ZERO, false).isPositiveRegenerationRate());
assertFalse(new RateLimiterConfig(1, Duration.ofSeconds(-1), false).isPositiveRegenerationRate());
}
}