mirror of
https://github.com/signalapp/Signal-Desktop.git
synced 2025-12-05 01:10:49 +00:00
Fix typing indicators for 1:1 conversations
This commit is contained in:
@@ -2186,7 +2186,7 @@ export async function startApp(): Promise<void> {
|
||||
|
||||
if (isGroup(conversation.attributes)) {
|
||||
// We drop typing notifications in groups we're not a part of
|
||||
if (!conversation.areWeAMember()) {
|
||||
if (!conversation.areWeAGroupMember()) {
|
||||
log.warn(
|
||||
`Received typing indicator for group ${conversation.idForLogging()}, which we're not a part of. Dropping.`
|
||||
);
|
||||
|
||||
@@ -1992,7 +1992,7 @@ export async function isGroupEligibleToMigrate(
|
||||
return false;
|
||||
}
|
||||
|
||||
const areWeMember = conversation.areWeAMember();
|
||||
const areWeMember = conversation.areWeAGroupMember();
|
||||
if (!areWeMember) {
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -327,7 +327,7 @@ export async function handleDataMessage(
|
||||
return;
|
||||
}
|
||||
|
||||
const areWeMember = conversation.areWeAMember();
|
||||
const areWeMember = conversation.areWeAGroupMember();
|
||||
|
||||
// Drop an incoming GroupV2 message if we or the sender are not part of the group
|
||||
// after applying the message's associated group changes.
|
||||
|
||||
@@ -1411,7 +1411,7 @@ export class ConversationModel {
|
||||
return;
|
||||
}
|
||||
|
||||
if (!this.areWeAMember()) {
|
||||
if (!isDirectConversation(this.attributes) && !this.areWeAGroupMember()) {
|
||||
log.warn(
|
||||
`sendTypingMessage(${this.idForLogging()}): not sending, we are not a member`
|
||||
);
|
||||
@@ -5379,7 +5379,7 @@ export class ConversationModel {
|
||||
return areWeAdmin(this.attributes);
|
||||
}
|
||||
|
||||
areWeAMember(): boolean {
|
||||
areWeAGroupMember(): boolean {
|
||||
return (
|
||||
!this.get('left') && this.hasMember(itemStorage.user.getCheckedAci())
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user