mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe.git synced 2025-12-05 01:10:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bump checkstyle and make inner classes final

Browse Source 
Updating checkstyle fixed a vulnerability and fixed a final class check in version 10.12.2 for local classes without constructor.  Local classes without a constructor should be marked as final. That is done in this commit.

For more info see https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.12.2
This commit is contained in:
tobigr
2025-10-05 21:13:18 +02:00
committed by Stypox
parent c8e294b1a3
commit 42f909936b
7 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/org/schabi/newpipe/fragments/list/search/SuggestionListAdapter.java
View File

@@ -76,7 +76,8 @@ public class SuggestionListAdapter
}
}
private static class SuggestionItemCallback extends DiffUtil.ItemCallback<SuggestionItem> {
private static final class SuggestionItemCallback
extends DiffUtil.ItemCallback<SuggestionItem> {
@Override
public boolean areItemsTheSame(@NonNull final SuggestionItem oldItem,
@NonNull final SuggestionItem newItem) {

3
app/src/main/java/org/schabi/newpipe/settings/PeertubeInstanceListFragment.java
View File

@@ -396,7 +396,8 @@ public class PeertubeInstanceListFragment extends Fragment {
}
}
private static class PeertubeInstanceCallback extends DiffUtil.ItemCallback<PeertubeInstance> {
private static final class PeertubeInstanceCallback
extends DiffUtil.ItemCallback<PeertubeInstance> {
@Override
public boolean areItemsTheSame(@NonNull final PeertubeInstance oldItem,
@NonNull final PeertubeInstance newItem) {

2
app/src/main/java/org/schabi/newpipe/settings/SelectChannelFragment.java
View File

@@ -174,7 +174,7 @@ public class SelectChannelFragment extends DialogFragment {
void onCancel();
}
private class SelectChannelAdapter
private final class SelectChannelAdapter
extends RecyclerView.Adapter<SelectChannelAdapter.SelectChannelItemHolder> {
@NonNull
@Override

2
app/src/main/java/org/schabi/newpipe/settings/SelectFeedGroupFragment.java
View File

@@ -175,7 +175,7 @@ public class SelectFeedGroupFragment extends DialogFragment {
void onCancel();
}
private class SelectFeedGroupAdapter
private final class SelectFeedGroupAdapter
extends RecyclerView.Adapter<SelectFeedGroupAdapter.SelectFeedGroupItemHolder> {
@NonNull
@Override

2
app/src/main/java/org/schabi/newpipe/settings/SelectPlaylistFragment.java
View File

@@ -138,7 +138,7 @@ public class SelectPlaylistFragment extends DialogFragment {
void onRemotePlaylistSelected(int serviceId, String url, String name);
}
private class SelectPlaylistAdapter
private final class SelectPlaylistAdapter
extends RecyclerView.Adapter<SelectPlaylistAdapter.SelectPlaylistItemHolder> {
@NonNull
@Override

3
app/src/main/java/org/schabi/newpipe/settings/preferencesearch/PreferenceSearchAdapter.java
View File

@@ -69,7 +69,8 @@ class PreferenceSearchAdapter
}
}
private static class PreferenceCallback extends DiffUtil.ItemCallback<PreferenceSearchItem> {
private static final class PreferenceCallback
extends DiffUtil.ItemCallback<PreferenceSearchItem> {
@Override
public boolean areItemsTheSame(@NonNull final PreferenceSearchItem oldItem,
@NonNull final PreferenceSearchItem newItem) {

2
gradle/libs.versions.toml
View File

@@ -11,7 +11,7 @@ assertj = "3.24.2"
autoservice = "1.1.1"
bridge = "v2.0.2"
cardview = "1.0.0"
checkstyle = "10.12.1"
checkstyle = "10.26.1"
constraintlayout = "2.1.4"
core = "1.12.0"
desugar = "2.0.4"