0bc4b2d337
Currently Clang use int32 to represent sampler_t, which have been a source of issue for some backends, because in some backends sampler_t cannot be represented by int32. They have to depend on kernel argument metadata and use IPA to find the sampler arguments and global variables and transform them to target specific sampler type.
This patch uses opaque pointer type opencl.sampler_t* for sampler_t. For each use of file-scope sampler variable, it generates a function call of __translate_sampler_initializer. For each initialization of function-scope sampler variable, it generates a function call of __translate_sampler_initializer.
Each builtin library can implement its own __translate_sampler_initializer(). Since the real sampler type tends to be architecture dependent, allowing it to be initialized by a library function simplifies backend design. A typical implementation of __translate_sampler_initializer could be a table lookup of real sampler literal values. Since its argument is always a literal, the returned pointer is known at compile time and easily optimized to finally become some literal values directly put into image read instructions.
This patch is partially based on Alexey Sotkin's work in Khronos Clang (3d4eec6162).
Differential Revision: https://reviews.llvm.org/D21567
llvm-svn: 277024
86 lines
3.8 KiB
Common Lisp
86 lines
3.8 KiB
Common Lisp
// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only
|
|
// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -DCHECK_SAMPLER_VALUE -Wspir-compat -triple amdgcn--amdhsa
|
|
// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -DCHECK_SAMPLER_VALUE -triple spir-unknown-unknown
|
|
|
|
#define CLK_ADDRESS_CLAMP_TO_EDGE 2
|
|
#define CLK_NORMALIZED_COORDS_TRUE 1
|
|
#define CLK_FILTER_NEAREST 0x10
|
|
#define CLK_FILTER_LINEAR 0x20
|
|
|
|
constant sampler_t glb_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR;
|
|
constant sampler_t glb_smp2; // expected-error{{variable in constant address space must be initialized}}
|
|
global sampler_t glb_smp3 = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_NEAREST; // expected-error{{sampler type cannot be used with the __local and __global address space qualifiers}}
|
|
|
|
constant sampler_t glb_smp4 = 0;
|
|
#ifdef CHECK_SAMPLER_VALUE
|
|
// expected-warning@-2{{sampler initializer has invalid Filter Mode bits}}
|
|
#endif
|
|
|
|
constant sampler_t glb_smp5 = 0x1f;
|
|
#ifdef CHECK_SAMPLER_VALUE
|
|
// expected-warning@-2{{sampler initializer has invalid Addressing Mode bits}}
|
|
#endif
|
|
|
|
constant sampler_t glb_smp6 = glb_smp; // expected-error{{initializer element is not a compile-time constant}}
|
|
|
|
int f(void);
|
|
constant sampler_t glb_smp7 = f(); // expected-error{{initializer element is not a compile-time constant}}
|
|
|
|
constant sampler_t glb_smp8 = 1.0f; // expected-error{{initializing '__constant sampler_t' with an expression of incompatible type 'float'}}
|
|
|
|
constant sampler_t glb_smp9 = 0x100000000LL; // expected-error{{sampler_t initialization requires 32-bit integer, not 'long long'}}
|
|
|
|
void foo(sampler_t);
|
|
|
|
constant struct sampler_s {
|
|
sampler_t smp; // expected-error{{the 'sampler_t' type cannot be used to declare a structure or union field}}
|
|
} sampler_str = {0};
|
|
|
|
sampler_t bad(void); //expected-error{{declaring function return value of type 'sampler_t' is not allowed}}
|
|
|
|
void kernel ker(sampler_t argsmp) {
|
|
local sampler_t smp; // expected-error{{sampler type cannot be used with the __local and __global address space qualifiers}}
|
|
const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR;
|
|
const sampler_t const_smp2;
|
|
const sampler_t const_smp3 = const_smp;
|
|
const sampler_t const_smp4 = f();
|
|
const sampler_t const_smp5 = 1.0f; // expected-error{{initializing 'const sampler_t' with an expression of incompatible type 'float'}}
|
|
const sampler_t const_smp6 = 0x100000000LL; // expected-error{{sampler_t initialization requires 32-bit integer, not 'long long'}}
|
|
|
|
foo(glb_smp);
|
|
foo(glb_smp2);
|
|
foo(glb_smp3);
|
|
foo(glb_smp4);
|
|
foo(glb_smp5);
|
|
foo(glb_smp6);
|
|
foo(glb_smp7);
|
|
foo(glb_smp8);
|
|
foo(glb_smp9);
|
|
foo(smp);
|
|
foo(sampler_str.smp);
|
|
foo(const_smp);
|
|
foo(const_smp2);
|
|
foo(const_smp3);
|
|
foo(const_smp4);
|
|
foo(const_smp5);
|
|
foo(const_smp6);
|
|
foo(argsmp);
|
|
foo(5); // expected-error{{sampler_t variable required - got 'int'}}
|
|
sampler_t sa[] = {argsmp, const_smp}; // expected-error {{array of 'sampler_t' type is invalid in OpenCL}}
|
|
foo(sa[0]);
|
|
foo(bad());
|
|
}
|
|
|
|
void bad(sampler_t*); // expected-error{{pointer to type 'sampler_t' is invalid in OpenCL}}
|
|
|
|
void bar() {
|
|
sampler_t smp1 = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR;
|
|
sampler_t smp2 = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_NEAREST;
|
|
smp1=smp2; //expected-error{{invalid operands to binary expression ('sampler_t' and 'sampler_t')}}
|
|
smp1+1; //expected-error{{invalid operands to binary expression ('sampler_t' and 'int')}}
|
|
&smp1; //expected-error{{invalid argument type 'sampler_t' to unary expression}}
|
|
*smp2; //expected-error{{invalid argument type 'sampler_t' to unary expression}}
|
|
foo(smp1+1); //expected-error{{invalid operands to binary expression ('sampler_t' and 'int')}}
|
|
}
|
|
|