1383ddc40b
Sema actions on ObjCDictionaryLiteral and ObjCArryLiteral are currently done as a side-effect of Sema upon parent expressions, which incurs of delayed typo corrections for such literals to be performed by TypoTransforms upon the ObjCDictionaryLiteral and ObjCArryLiteral themselves instead of its elements individually. This is specially bad because it was not designed to act on several elements; searching through all possible combinations of corrections for several elements is very expensive. Additionally, when one of the elements has no correction candidate, we still explore all options and at the end emit no typo corrections whatsoever. Do the proper sema actions by acting on each element alone during appropriate literal parsing time to get proper diagonistics and decent compile time behavior. Differential Revision: http://reviews.llvm.org/D22183 rdar://problem/21046678 llvm-svn: 276020
73 lines
2.4 KiB
Objective-C
73 lines
2.4 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
// rdar://11062080
|
|
// RUN: %clang_cc1 -fsyntax-only -triple i386-apple-macosx10.9.0 -fobjc-runtime=macosx-fragile-10.9.0 -fobjc-subscripting-legacy-runtime -verify %s
|
|
// rdar://15363492
|
|
|
|
#define nil ((void *)0)
|
|
|
|
void checkNSDictionaryUnavailableDiagnostic() {
|
|
id key;
|
|
id value;
|
|
id dict = @{ key : value }; // expected-error {{definition of class NSDictionary must be available to use Objective-C dictionary literals}}
|
|
}
|
|
|
|
@class NSDictionary; // expected-note {{forward declaration of class here}}
|
|
|
|
void checkNSDictionaryFDDiagnostic() {
|
|
id key;
|
|
id value;
|
|
id dic = @{ key : value }; // expected-error {{definition of class NSDictionary must be available to use Objective-C dictionary literals}}
|
|
}
|
|
|
|
@interface NSNumber
|
|
+ (NSNumber *)numberWithChar:(char)value;
|
|
+ (NSNumber *)numberWithInt:(int)value;
|
|
@end
|
|
|
|
@protocol NSCopying @end
|
|
typedef unsigned long NSUInteger;
|
|
typedef long NSInteger;
|
|
|
|
@interface NSDictionary
|
|
+ (id)dictionaryWithObjects:(const id [])objects forKeys:(const id <NSCopying> [])keys count:(NSUInteger)cnt;
|
|
- (void)setObject:(id)object forKeyedSubscript:(id)key;
|
|
- (id)objectForKeyedSubscript:(id)key;
|
|
@end
|
|
|
|
@interface NSString<NSCopying>
|
|
@end
|
|
|
|
@interface NSArray
|
|
- (id)objectAtIndexedSubscript:(NSInteger)index;
|
|
- (void)setObject:(id)object atIndexedSubscript:(NSInteger)index;
|
|
@end
|
|
|
|
void *pvoid;
|
|
int main() {
|
|
NSDictionary *dict = @{ @"name":@666 };
|
|
dict[@"name"] = @666;
|
|
|
|
dict["name"] = @666; // expected-error {{indexing expression is invalid because subscript type 'char *' is not an Objective-C pointer}}
|
|
|
|
// rdar://18254621
|
|
[@{@"foo" : @"bar"} objectForKeyedSubscript:nil];
|
|
(void)@{@"foo" : @"bar"}[nil];
|
|
[@{@"foo" : @"bar"} objectForKeyedSubscript:pvoid];
|
|
(void)@{@"foo" : @"bar"}[pvoid];
|
|
|
|
[@{@"foo" : @"bar"} setObject:nil forKeyedSubscript:@"gorf"];
|
|
@{@"foo" : @"bar"}[nil] = @"gorf";
|
|
[@{@"foo" : @"bar"} setObject:pvoid forKeyedSubscript:@"gorf"];
|
|
@{@"foo" : @"bar"}[pvoid] = @"gorf";
|
|
|
|
return 0;
|
|
}
|
|
|
|
enum XXXYYYZZZType { XXXYYYZZZTypeAny }; // expected-note {{'XXXYYYZZZTypeAny' declared here}}
|
|
void foo() {
|
|
NSDictionary *d = @{
|
|
@"A" : @(XXXYYYZZZTypeA), // expected-error {{use of undeclared identifier 'XXXYYYZZZTypeA'; did you mean 'XXXYYYZZZTypeAny'}}
|
|
@"F" : @(XXXYYYZZZTypeSomethingSomething), // expected-error {{use of undeclared identifier 'XXXYYYZZZTypeSomethingSomething'}}
|
|
};
|
|
}
|