Files
llvm-project/clang/test/CodeGenCXX/microsoft-abi-vtables-multiple-nonvirtual-inheritance-this-adjustment.cpp
Reid Kleckner e5a321b5e8 [MS] Fix prologue this adjustment when 'this' is passed indirectly
Move the logic for doing this from the ABI argument lowering into
EmitParmDecl, which runs for all parameters. Our codegen is slightly
suboptimal in this case, as we may leave behind a dead store after
optimization, but it's 32-bit inalloca, and this fixes the bug in a
robust way.

Fixes PR30293

llvm-svn: 280836
2016-09-07 18:21:30 +00:00

203 lines
5.5 KiB
C++

// RUN: %clang_cc1 %s -fno-rtti -triple=i386-pc-win32 -emit-llvm -o %t.ll -fdump-vtable-layouts >%t
// RUN: FileCheck %s < %t
// RUN: FileCheck --check-prefix=BITCODE %s < %t.ll
namespace test1 {
struct A {
virtual void g();
// Add an extra virtual method so it's easier to check for the absence of thunks.
virtual void h();
};
struct B {
virtual void g(); // Collides with A::g if both are bases of some class.
};
// Overrides methods of two bases at the same time, thus needing thunks.
struct X : A, B {
// CHECK-LABEL: VFTable for 'test1::A' in 'test1::X' (2 entries).
// CHECK-NEXT: 0 | void test1::X::g()
// CHECK-NEXT: 1 | void test1::A::h()
// CHECK-LABEL: VFTable for 'test1::B' in 'test1::X' (1 entry).
// CHECK-NEXT: 0 | void test1::X::g()
// CHECK-NEXT: [this adjustment: -4 non-virtual]
// CHECK-LABEL: Thunks for 'void test1::X::g()' (1 entry).
// CHECK-NEXT: 0 | [this adjustment: -4 non-virtual]
// CHECK-LABEL: VFTable indices for 'test1::X' (1 entry).
// CHECK-NEXT: 0 | void test1::X::g()
// BITCODE-DAG: @"\01??_7X@test1@@6BA@1@@"
// BITCODE-DAG: @"\01??_7X@test1@@6BB@1@@"
virtual void g();
} x;
void build_vftable(X *obj) { obj->g(); }
}
namespace test2 {
struct A {
virtual void f();
};
struct B {
virtual void g();
virtual void h();
};
struct C {
virtual void g();
};
struct X : A, B, C {
// CHECK-LABEL: VFTable for 'test2::A' in 'test2::X' (1 entry).
// CHECK-NEXT: 0 | void test2::A::f()
// CHECK-LABEL: VFTable for 'test2::B' in 'test2::X' (2 entries).
// CHECK-NEXT: 0 | void test2::X::g()
// CHECK-NEXT: 1 | void test2::B::h()
// CHECK-LABEL: VFTable for 'test2::C' in 'test2::X' (1 entry).
// CHECK-NEXT: 0 | void test2::X::g()
// CHECK-NEXT: [this adjustment: -4 non-virtual]
// CHECK-LABEL: Thunks for 'void test2::X::g()' (1 entry).
// CHECK-NEXT: 0 | [this adjustment: -4 non-virtual]
// CHECK-LABEL: VFTable indices for 'test2::X' (1 entry).
// CHECK-NEXT: via vfptr at offset 4
// CHECK-NEXT: 0 | void test2::X::g()
// BITCODE-DAG: @"\01??_7X@test2@@6BA@1@@"
// BITCODE-DAG: @"\01??_7X@test2@@6BB@1@@"
// BITCODE-DAG: @"\01??_7X@test2@@6BC@1@@"
virtual void g();
} x;
void build_vftable(X *obj) { obj->g(); }
}
namespace test3 {
struct A {
virtual void f();
};
struct B {
virtual void g();
virtual void h();
};
struct C: A, B {
// Overrides only the left child's method (A::f), needs no thunks.
virtual void f();
};
struct D: A, B {
// Overrides only the right child's method (B::g),
// needs this adjustment but not thunks.
virtual void g();
};
// Overrides methods of two bases at the same time, thus needing thunks.
struct X: C, D {
// CHECK-LABEL: VFTable for 'test3::A' in 'test3::C' in 'test3::X' (1 entry).
// CHECK-NEXT: 0 | void test3::X::f()
// CHECK-LABEL: VFTable for 'test3::B' in 'test3::C' in 'test3::X' (2 entries).
// CHECK-NEXT: 0 | void test3::X::g()
// CHECK-NEXT: 1 | void test3::B::h()
// CHECK-LABEL: VFTable for 'test3::A' in 'test3::D' in 'test3::X' (1 entry).
// CHECK-NEXT: 0 | void test3::X::f()
// CHECK-NEXT: [this adjustment: -8 non-virtual]
// CHECK-LABEL: Thunks for 'void test3::X::f()' (1 entry).
// CHECK-NEXT: 0 | [this adjustment: -8 non-virtual]
// CHECK-LABEL: VFTable for 'test3::B' in 'test3::D' in 'test3::X' (2 entries).
// CHECK-NEXT: 0 | void test3::X::g()
// CHECK-NEXT: [this adjustment: -8 non-virtual]
// CHECK-NEXT: 1 | void test3::B::h()
// CHECK-LABEL: Thunks for 'void test3::X::g()' (1 entry).
// CHECK-NEXT: 0 | [this adjustment: -8 non-virtual]
// CHECK-LABEL: VFTable indices for 'test3::X' (2 entries).
// CHECK-NEXT: via vfptr at offset 0
// CHECK-NEXT: 0 | void test3::X::f()
// CHECK-NEXT: via vfptr at offset 4
// CHECK-NEXT: 0 | void test3::X::g()
virtual void f();
virtual void g();
} x;
void build_vftable(X *obj) { obj->g(); }
}
namespace test4 {
struct A {
virtual void foo();
};
struct B {
virtual int filler();
virtual int operator-();
virtual int bar();
};
struct C : public A, public B {
virtual int filler();
virtual int operator-();
virtual int bar();
};
// BITCODE-LABEL: define {{.*}}\01?ffun@test4@@YAXAAUC@1@@Z
void ffun(C &c) {
// BITCODE: load
// BITCODE: bitcast
// BITCODE: bitcast
// BITCODE: [[THIS1:%.+]] = bitcast %"struct.test4::C"* {{.*}} to i8*
// BITCODE: [[THIS2:%.+]] = getelementptr inbounds i8, i8* [[THIS1]], i32 4
// BITCODE-NEXT: call x86_thiscallcc {{.*}}(i8* [[THIS2]])
c.bar();
}
// BITCODE-LABEL: define {{.*}}\01?fop@test4@@YAXAAUC@1@@Z
void fop(C &c) {
// BITCODE: load
// BITCODE: bitcast
// BITCODE: bitcast
// BITCODE: [[THIS1:%.+]] = bitcast %"struct.test4::C"* {{.*}} to i8*
// BITCODE: [[THIS2:%.+]] = getelementptr inbounds i8, i8* [[THIS1]], i32 4
// BITCODE-NEXT: call x86_thiscallcc {{.*}}(i8* [[THIS2]])
-c;
}
}
namespace pr30293 {
struct NonTrivial {
~NonTrivial();
int x;
};
struct A { virtual void f(); };
struct B { virtual void __cdecl g(NonTrivial); };
struct C final : A, B {
void f() override;
void __cdecl g(NonTrivial) override;
};
C *whatsthis;
void C::f() { g(NonTrivial()); }
void C::g(NonTrivial o) {
whatsthis = this;
}
// BITCODE-LABEL: define void @"\01?g@C@pr30293@@UAAXUNonTrivial@2@@Z"(<{ i8*, %"struct.pr30293::NonTrivial" }>* inalloca)
// BITCODE: %[[this1:[^ ]*]] = load i8*, i8** %[[thisaddr:[^ ]*]], align 4
// BITCODE-NEXT: %[[this2:[^ ]*]] = getelementptr inbounds i8, i8* %[[this1]], i32 -4
// BITCODE-NEXT: store i8* %[[this2]], i8** %[[thisaddr]], align 4
}