489cfe1401
This comes up when a derived class destructor is equivalent to a base class destructor defined in the same TU, and we try to alias them. A COFF weak alias cannot satisfy a normal undefined symbol reference from another TU. The other TU must also mark the referenced symbol as weak, and we can't rely on that. Clang already has a special case here for dllexport, but we failed to realize that the problem also applies to other non-discardable symbols such as those from explicit template instantiations. Fixes PR25477. llvm-svn: 252659
43 lines
1011 B
C++
43 lines
1011 B
C++
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=i386-pc-win32 -fno-rtti -mconstructor-aliases -O1 -disable-llvm-optzns | FileCheck %s
|
|
|
|
namespace test1 {
|
|
template <typename T> class A {
|
|
~A() {}
|
|
};
|
|
template class A<char>;
|
|
// CHECK-DAG: define weak_odr x86_thiscallcc void @"\01??1?$A@D@test1@@AAE@XZ"
|
|
}
|
|
|
|
namespace test2 {
|
|
struct A {
|
|
virtual ~A();
|
|
};
|
|
struct B : A {
|
|
B();
|
|
virtual ~B();
|
|
};
|
|
|
|
A::~A() {}
|
|
B::~B() {}
|
|
void foo() {
|
|
B b;
|
|
}
|
|
// CHECK-DAG: @"\01??1B@test2@@UAE@XZ" = alias void (%"struct.test2::B"*), bitcast (void (%"struct.test2::A"*)* @"\01??1A@test2@@UAE@XZ" to void (%"struct.test2::B"*)*)
|
|
}
|
|
|
|
namespace test3 {
|
|
struct A { virtual ~A(); };
|
|
A::~A() {}
|
|
}
|
|
// CHECK-DAG: define x86_thiscallcc void @"\01??1A@test3@@UAE@XZ"(
|
|
namespace test3 {
|
|
template <typename T>
|
|
struct B : A {
|
|
virtual ~B() { }
|
|
};
|
|
template struct B<int>;
|
|
}
|
|
// This has to be weak, and emitting weak aliases is fragile, so we don't do the
|
|
// aliasing.
|
|
// CHECK-DAG: define weak_odr x86_thiscallcc void @"\01??1?$B@H@test3@@UAE@XZ"(
|