f1a6552a95
Summary:
This patch renames checks, check options and changes messages to use correct
term "implicit conversion" instead of "implicit cast" (which has been in use in
Clang AST since ~10 years, but it's still technically incorrect w.r.t. C++
standard).
* performance-implicit-cast-in-loop -> performance-implicit-conversion-in-loop
* readability-implicit-bool-cast -> readability-implicit-bool-conversion
- readability-implicit-bool-cast.AllowConditionalIntegerCasts ->
readability-implicit-bool-conversion.AllowIntegerConditions
- readability-implicit-bool-cast.AllowConditionalPointerCasts ->
readability-implicit-bool-conversion.AllowPointerConditions
Reviewers: hokein, jdennett
Reviewed By: hokein
Subscribers: mgorny, JDevlieghere, xazax.hun, cfe-commits
Differential Revision: https://reviews.llvm.org/D36456
llvm-svn: 310366
67 lines
2.6 KiB
C++
67 lines
2.6 KiB
C++
// RUN: %check_clang_tidy %s readability-implicit-bool-conversion %t \
|
|
// RUN: -config='{CheckOptions: \
|
|
// RUN: [{key: readability-implicit-bool-conversion.AllowIntegerConditions, value: 1}, \
|
|
// RUN: {key: readability-implicit-bool-conversion.AllowPointerConditions, value: 1}]}' \
|
|
// RUN: -- -std=c++11
|
|
|
|
template<typename T>
|
|
void functionTaking(T);
|
|
|
|
int functionReturningInt();
|
|
int* functionReturningPointer();
|
|
|
|
struct Struct {
|
|
int member;
|
|
};
|
|
|
|
|
|
void regularImplicitConversionIntegerToBoolIsNotIgnored() {
|
|
int integer = 0;
|
|
functionTaking<bool>(integer);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
|
|
// CHECK-FIXES: functionTaking<bool>(integer != 0);
|
|
}
|
|
|
|
void implicitConversionIntegerToBoolInConditionalsIsAllowed() {
|
|
if (functionReturningInt()) {}
|
|
if (!functionReturningInt()) {}
|
|
if (functionReturningInt() && functionReturningPointer()) {}
|
|
if (!functionReturningInt() && !functionReturningPointer()) {}
|
|
for (; functionReturningInt(); ) {}
|
|
for (; functionReturningPointer(); ) {}
|
|
for (; functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer()); ) {}
|
|
while (functionReturningInt()) {}
|
|
while (functionReturningPointer()) {}
|
|
while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer())) {}
|
|
int value1 = functionReturningInt() ? 1 : 2;
|
|
int value2 = !functionReturningInt() ? 1 : 2;
|
|
int value3 = (functionReturningInt() && functionReturningPointer() || !functionReturningInt()) ? 1 : 2;
|
|
int value4 = functionReturningInt() ?: value3;
|
|
int *p1 = functionReturningPointer() ?: &value3;
|
|
}
|
|
|
|
void regularImplicitConversionPointerToBoolIsNotIgnored() {
|
|
int* pointer = nullptr;
|
|
functionTaking<bool>(pointer);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'int *' -> bool
|
|
// CHECK-FIXES: functionTaking<bool>(pointer != nullptr);
|
|
|
|
int Struct::* memberPointer = &Struct::member;
|
|
functionTaking<bool>(memberPointer);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'int Struct::*' -> bool
|
|
// CHECK-FIXES: functionTaking<bool>(memberPointer != nullptr);
|
|
}
|
|
|
|
void implicitConversionPointerToBoolInConditionalsIsAllowed() {
|
|
if (functionReturningPointer()) {}
|
|
if (not functionReturningPointer()) {}
|
|
int value1 = functionReturningPointer() ? 1 : 2;
|
|
int value2 = (not functionReturningPointer()) ? 1 : 2;
|
|
|
|
int Struct::* memberPointer = &Struct::member;
|
|
if (memberPointer) {}
|
|
if (memberPointer) {}
|
|
int value3 = memberPointer ? 1 : 2;
|
|
int value4 = (not memberPointer) ? 1 : 2;
|
|
}
|