09464e63d8
Fix for __declspec attributes and const=0 without space
This patch is to address 2 problems I found with Clang-tidy:modernize-use-override.
1: missing spaces on pure function decls.
Orig:
void pure() const=0
Problem:
void pure() constoverride =0
Fixed:
void pure() const override =0
2: This is ms-extension specific, but possibly applies to other attribute types. The override is placed before the attribute which doesn’t work well with declspec as this attribute can be inherited or placed before the method identifier.
Orig:
class __declspec(dllexport) X : public Y
{
void p();
};
Problem:
class override __declspec(dllexport) class X : public Y
{
void p();
};
Fixed:
class __declspec(dllexport) class X : public Y
{
void p() override;
};
Patch by Robert Bolter!
Differential Revision: http://reviews.llvm.org/D18396
llvm-svn: 265298
26 lines
813 B
C++
26 lines
813 B
C++
// RUN: %check_clang_tidy %s modernize-use-override %t -- -- -fms-extensions -std=c++11
|
|
|
|
// This test is designed to test ms-extension __declspec(dllexport) attributes.
|
|
#define EXPORT __declspec(dllexport)
|
|
|
|
class Base {
|
|
virtual EXPORT void a();
|
|
};
|
|
|
|
class EXPORT InheritedBase {
|
|
virtual void a();
|
|
};
|
|
|
|
class Derived : public Base {
|
|
virtual EXPORT void a();
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:23: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
|
|
// CHECK-FIXES: {{^}} EXPORT void a() override;
|
|
};
|
|
|
|
class EXPORT InheritedDerived : public InheritedBase {
|
|
virtual void a();
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
|
|
// CHECK-FIXES: {{^}} void a() override;
|
|
};
|
|
|