d4ac4afda7
Summary: clang_tidy/rename_check.py misc-assert-side-effect bugprone-assert-side-effect clang_tidy/rename_check.py misc-bool-pointer-implicit-conversion bugprone-bool-pointer-implicit-conversion clang_tidy/rename_check.py misc-fold-init-type bugprone-fold-init-type clang_tidy/rename_check.py misc-forward-declaration-namespace bugprone-forward-declaration-namespace clang_tidy/rename_check.py misc-inaccurate-erase bugprone-inaccurate-erase clang_tidy/rename_check.py misc-move-forwarding-reference bugprone-move-forwarding-reference clang_tidy/rename_check.py misc-multiple-statement-macro bugprone-multiple-statement-macro clang_tidy/rename_check.py misc-use-after-move bugprone-use-after-move clang_tidy/rename_check.py misc-virtual-near-miss bugprone-virtual-near-miss Manually fixed a reference to UseAfterMoveCheck in the hicpp module. Manually fixed header guards. Reviewers: hokein Reviewed By: hokein Subscribers: nemanjai, mgorny, javed.absar, xazax.hun, kbarton, cfe-commits Differential Revision: https://reviews.llvm.org/D40426 llvm-svn: 318950
115 lines
3.4 KiB
C++
115 lines
3.4 KiB
C++
// RUN: %check_clang_tidy %s bugprone-assert-side-effect %t -- -config="{CheckOptions: [{key: bugprone-assert-side-effect.CheckFunctionCalls, value: 1}, {key: bugprone-assert-side-effect.AssertMacros, value: 'assert,assert2,my_assert,convoluted_assert,msvc_assert'}]}" -- -fexceptions
|
|
|
|
//===--- assert definition block ------------------------------------------===//
|
|
int abort() { return 0; }
|
|
|
|
#ifdef NDEBUG
|
|
#define assert(x) 1
|
|
#else
|
|
#define assert(x) \
|
|
if (!(x)) \
|
|
(void)abort()
|
|
#endif
|
|
|
|
void print(...);
|
|
#define assert2(e) (__builtin_expect(!(e), 0) ? \
|
|
print (#e, __FILE__, __LINE__) : (void)0)
|
|
|
|
#ifdef NDEBUG
|
|
#define my_assert(x) 1
|
|
#else
|
|
#define my_assert(x) \
|
|
((void)((x) ? 1 : abort()))
|
|
#endif
|
|
|
|
#ifdef NDEBUG
|
|
#define not_my_assert(x) 1
|
|
#else
|
|
#define not_my_assert(x) \
|
|
if (!(x)) \
|
|
(void)abort()
|
|
#endif
|
|
|
|
#define real_assert(x) ((void)((x) ? 1 : abort()))
|
|
#define wrap1(x) real_assert(x)
|
|
#define wrap2(x) wrap1(x)
|
|
#define convoluted_assert(x) wrap2(x)
|
|
|
|
#define msvc_assert(expression) (void)( \
|
|
(!!(expression)) || \
|
|
(abort(), 0) \
|
|
)
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
class MyClass {
|
|
public:
|
|
bool badFunc(int a, int b) { return a * b > 0; }
|
|
bool goodFunc(int a, int b) const { return a * b > 0; }
|
|
|
|
MyClass &operator=(const MyClass &rhs) { return *this; }
|
|
|
|
int operator-() { return 1; }
|
|
|
|
operator bool() const { return true; }
|
|
|
|
void operator delete(void *p) {}
|
|
};
|
|
|
|
bool freeFunction() {
|
|
return true;
|
|
}
|
|
|
|
int main() {
|
|
|
|
int X = 0;
|
|
bool B = false;
|
|
assert(X == 1);
|
|
|
|
assert(X = 1);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect [bugprone-assert-side-effect]
|
|
my_assert(X = 1);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found my_assert() with side effect
|
|
convoluted_assert(X = 1);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found convoluted_assert() with side effect
|
|
not_my_assert(X = 1);
|
|
|
|
assert(++X);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
|
|
assert(!B);
|
|
|
|
assert(B || true);
|
|
|
|
assert(freeFunction());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
|
|
|
|
MyClass mc;
|
|
assert(mc.badFunc(0, 1));
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
|
|
assert(mc.goodFunc(0, 1));
|
|
|
|
MyClass mc2;
|
|
assert(mc2 = mc);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
|
|
|
|
assert(-mc > 0);
|
|
|
|
MyClass *mcp;
|
|
assert(mcp = new MyClass);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
|
|
|
|
assert((delete mcp, false));
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
|
|
|
|
assert((throw 1, false));
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
|
|
|
|
assert2(1 == 2 - 1);
|
|
|
|
msvc_assert(mc2 = mc);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found msvc_assert() with side effect
|
|
|
|
return 0;
|
|
}
|