24340252a4
Summary: -- fopen() should include "e" in their mode string. [android-fopen-mode] Reviewers: chh, alexfh, aaron.ballman, hokein Reviewed By: hokein Subscribers: JDevlieghere, srhines, mgorny, xazax.hun Tags: #clang-tools-extra Differential Revision: https://reviews.llvm.org/D33747 llvm-svn: 306709
58 lines
1.4 KiB
C++
58 lines
1.4 KiB
C++
// RUN: %check_clang_tidy %s android-cloexec-fopen %t
|
|
|
|
#define FILE_OPEN_RO "r"
|
|
|
|
typedef int FILE;
|
|
|
|
extern "C" FILE *fopen(const char *filename, const char *mode, ...);
|
|
extern "C" FILE *open(const char *filename, const char *mode, ...);
|
|
|
|
void f() {
|
|
fopen("filename", "r");
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: use 'fopen' mode 'e' to set O_CLOEXEC [android-cloexec-fopen]
|
|
// CHECK-FIXES: fopen("filename", "re");
|
|
|
|
fopen("filename", FILE_OPEN_RO);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: use 'fopen' mode 'e'
|
|
// CHECK-FIXES: fopen("filename", FILE_OPEN_RO "e");
|
|
|
|
fopen("filename", "er");
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
fopen("filename", "re");
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
fopen("filename", "e");
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
open("filename", "e");
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
|
|
char *str = "r";
|
|
fopen("filename", str);
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
str = "re";
|
|
fopen("filename", str);
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
char arr[2] = "r";
|
|
fopen("filename", arr);
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
char arr2[3] = "re";
|
|
fopen("filename", arr2);
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
}
|
|
|
|
namespace i {
|
|
int *fopen(const char *filename, const char *mode, ...);
|
|
void g() {
|
|
fopen("filename", "e");
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
}
|
|
} // namespace i
|
|
|
|
class C {
|
|
public:
|
|
int *fopen(const char *filename, const char *mode, ...);
|
|
void h() {
|
|
fopen("filename", "e");
|
|
// CHECK-MESSAGES-NOT: warning:
|
|
}
|
|
};
|