7f8827576c
Summary: Make check more useful in the following two cases: The parameter is passed by non-const value, has a non-deleted move constructor and is only referenced once in the function as argument to the type's copy constructor. The parameter is passed by non-const value, has a non-deleted move assignment operator and is only referenced once in the function as argument of the the type's copy assignment operator. In this case suggest a fix to move the parameter which avoids the unnecessary copy and is closest to what the user might have intended. Reviewers: alexfh, sbenza Subscribers: cfe-commits, Prazek Differential Revision: http://reviews.llvm.org/D20277 llvm-svn: 274380
46 lines
1.7 KiB
C++
46 lines
1.7 KiB
C++
//===--- UnnecessaryValueParamCheck.h - clang-tidy---------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_PERFORMANCE_UNNECESSARY_VALUE_PARAM_H
|
|
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_PERFORMANCE_UNNECESSARY_VALUE_PARAM_H
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../utils/IncludeInserter.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace performance {
|
|
|
|
/// \brief A check that flags value parameters of expensive to copy types that
|
|
/// can safely be converted to const references.
|
|
///
|
|
/// For the user-facing documentation see:
|
|
/// http://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html
|
|
class UnnecessaryValueParamCheck : public ClangTidyCheck {
|
|
public:
|
|
UnnecessaryValueParamCheck(StringRef Name, ClangTidyContext *Context);
|
|
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
|
|
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
|
|
void registerPPCallbacks(CompilerInstance &Compiler) override;
|
|
void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
|
|
|
|
private:
|
|
void handleMoveFix(const ParmVarDecl &Var, const DeclRefExpr &CopyArgument,
|
|
const ASTContext &Context);
|
|
|
|
std::unique_ptr<utils::IncludeInserter> Inserter;
|
|
const utils::IncludeSorter::IncludeStyle IncludeStyle;
|
|
};
|
|
|
|
} // namespace performance
|
|
} // namespace tidy
|
|
} // namespace clang
|
|
|
|
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_PERFORMANCE_UNNECESSARY_VALUE_PARAM_H
|