2f20b36cc3
Summary: This check finds the use of methods related to OSSpinlock in Objective-C code, which should be deprecated due to livelock issues. The following method call will be detected: - OSSpinlockLock() - OSSpinlockTry() - OSSpinlockUnlcok() Reviewers: hokein, benhamilton Reviewed By: benhamilton Subscribers: klimek, cfe-commits, mgorny Differential Revision: https://reviews.llvm.org/D40325 llvm-svn: 319098
38 lines
1.1 KiB
C++
38 lines
1.1 KiB
C++
//===--- AvoidSpinlockCheck.cpp - clang-tidy-------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "AvoidSpinlockCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace objc {
|
|
|
|
void AvoidSpinlockCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(
|
|
callExpr(callee((functionDecl(hasAnyName(
|
|
"OSSpinlockLock", "OSSpinlockUnlock", "OSSpinlockTry")))))
|
|
.bind("spinlock"),
|
|
this);
|
|
}
|
|
|
|
void AvoidSpinlockCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedExpr = Result.Nodes.getNodeAs<CallExpr>("spinlock");
|
|
diag(MatchedExpr->getLocStart(),
|
|
"use os_unfair_lock_lock() or dispatch queue APIs instead of the "
|
|
"deprecated OSSpinLock");
|
|
}
|
|
|
|
} // namespace objc
|
|
} // namespace tidy
|
|
} // namespace clang
|