1f696b316c
Summary:
This check is finding suspicious cases of sizeof expression.
Sizeof expression is returning the size (in bytes) of a type or an
expression. Programmers often abuse or misuse this expression.
This checker is adding common set of patterns to detect some
of these bad constructs.
Some examples found by this checker:
R/packages/ifultools/ifultools/src/fra_neig.c
```
/* free buffer memory */
(void) mutil_free( dist_buff, sizeof( ctr * sizeof( double ) ) );
(void) mutil_free( nidx_buff, sizeof( ctr * sizeof( sint32 ) ) );
```
graphviz/v2_20_2/lib/common/utils.c
```
static Dtdisc_t mapDisc = {
offsetof(item, p),
sizeof(2 * sizeof(void *)),
offsetof(item, link),
(Dtmake_f) newItem,
(Dtfree_f) freeItem,
(Dtcompar_f) cmpItem,
NIL(Dthash_f),
NIL(Dtmemory_f),
NIL(Dtevent_f)
};
```
mDNSResponder/mDNSShared/dnsextd.c
```
context = ( TCPContext* ) malloc( sizeof( TCPContext ) );
require_action( context, exit, err = mStatus_NoMemoryErr; LogErr( "AcceptTCPConnection", "malloc" ) );
mDNSPlatformMemZero( context, sizeof( sizeof( TCPContext ) ) );
context->d = self;
```
Reviewers: alexfh
Subscribers: malcolm.parsons, Eugene.Zelenko, cfe-commits
Differential Revision: http://reviews.llvm.org/D19014
llvm-svn: 266451
138 lines
5.7 KiB
C++
138 lines
5.7 KiB
C++
//===--- MiscTidyModule.cpp - clang-tidy ----------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../ClangTidyModule.h"
|
|
#include "../ClangTidyModuleRegistry.h"
|
|
#include "ArgumentCommentCheck.h"
|
|
#include "AssertSideEffectCheck.h"
|
|
#include "AssignOperatorSignatureCheck.h"
|
|
#include "BoolPointerImplicitConversionCheck.h"
|
|
#include "DanglingHandleCheck.h"
|
|
#include "DefinitionsInHeadersCheck.h"
|
|
#include "ForwardDeclarationNamespaceCheck.h"
|
|
#include "InaccurateEraseCheck.h"
|
|
#include "IncorrectRoundings.h"
|
|
#include "InefficientAlgorithmCheck.h"
|
|
#include "MacroParenthesesCheck.h"
|
|
#include "MacroRepeatedSideEffectsCheck.h"
|
|
#include "MisplacedWideningCastCheck.h"
|
|
#include "MoveConstantArgumentCheck.h"
|
|
#include "MoveConstructorInitCheck.h"
|
|
#include "MultipleStatementMacroCheck.h"
|
|
#include "NewDeleteOverloadsCheck.h"
|
|
#include "NoexceptMoveConstructorCheck.h"
|
|
#include "NonCopyableObjects.h"
|
|
#include "PointerAndIntegralOperationCheck.h"
|
|
#include "SizeofContainerCheck.h"
|
|
#include "SizeofExpressionCheck.h"
|
|
#include "StaticAssertCheck.h"
|
|
#include "StringIntegerAssignmentCheck.h"
|
|
#include "StringLiteralWithEmbeddedNulCheck.h"
|
|
#include "SuspiciousMissingCommaCheck.h"
|
|
#include "SuspiciousSemicolonCheck.h"
|
|
#include "SwappedArgumentsCheck.h"
|
|
#include "ThrowByValueCatchByReferenceCheck.h"
|
|
#include "UndelegatedConstructor.h"
|
|
#include "UniqueptrResetReleaseCheck.h"
|
|
#include "UnusedAliasDeclsCheck.h"
|
|
#include "UnusedParametersCheck.h"
|
|
#include "UnusedRAIICheck.h"
|
|
#include "VirtualNearMissCheck.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace misc {
|
|
|
|
class MiscModule : public ClangTidyModule {
|
|
public:
|
|
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
|
|
CheckFactories.registerCheck<ArgumentCommentCheck>("misc-argument-comment");
|
|
CheckFactories.registerCheck<AssertSideEffectCheck>(
|
|
"misc-assert-side-effect");
|
|
CheckFactories.registerCheck<AssignOperatorSignatureCheck>(
|
|
"misc-assign-operator-signature");
|
|
CheckFactories.registerCheck<BoolPointerImplicitConversionCheck>(
|
|
"misc-bool-pointer-implicit-conversion");
|
|
CheckFactories.registerCheck<DanglingHandleCheck>(
|
|
"misc-dangling-handle");
|
|
CheckFactories.registerCheck<DefinitionsInHeadersCheck>(
|
|
"misc-definitions-in-headers");
|
|
CheckFactories.registerCheck<ForwardDeclarationNamespaceCheck>(
|
|
"misc-forward-declaration-namespace");
|
|
CheckFactories.registerCheck<InaccurateEraseCheck>(
|
|
"misc-inaccurate-erase");
|
|
CheckFactories.registerCheck<IncorrectRoundings>(
|
|
"misc-incorrect-roundings");
|
|
CheckFactories.registerCheck<InefficientAlgorithmCheck>(
|
|
"misc-inefficient-algorithm");
|
|
CheckFactories.registerCheck<MacroParenthesesCheck>(
|
|
"misc-macro-parentheses");
|
|
CheckFactories.registerCheck<MacroRepeatedSideEffectsCheck>(
|
|
"misc-macro-repeated-side-effects");
|
|
CheckFactories.registerCheck<MisplacedWideningCastCheck>(
|
|
"misc-misplaced-widening-cast");
|
|
CheckFactories.registerCheck<MoveConstantArgumentCheck>(
|
|
"misc-move-const-arg");
|
|
CheckFactories.registerCheck<MoveConstructorInitCheck>(
|
|
"misc-move-constructor-init");
|
|
CheckFactories.registerCheck<MultipleStatementMacroCheck>(
|
|
"misc-multiple-statement-macro");
|
|
CheckFactories.registerCheck<NewDeleteOverloadsCheck>(
|
|
"misc-new-delete-overloads");
|
|
CheckFactories.registerCheck<NoexceptMoveConstructorCheck>(
|
|
"misc-noexcept-move-constructor");
|
|
CheckFactories.registerCheck<NonCopyableObjectsCheck>(
|
|
"misc-non-copyable-objects");
|
|
CheckFactories.registerCheck<PointerAndIntegralOperationCheck>(
|
|
"misc-pointer-and-integral-operation");
|
|
CheckFactories.registerCheck<SizeofContainerCheck>("misc-sizeof-container");
|
|
CheckFactories.registerCheck<SizeofExpressionCheck>(
|
|
"misc-sizeof-expression");
|
|
CheckFactories.registerCheck<StaticAssertCheck>(
|
|
"misc-static-assert");
|
|
CheckFactories.registerCheck<StringIntegerAssignmentCheck>(
|
|
"misc-string-integer-assignment");
|
|
CheckFactories.registerCheck<StringLiteralWithEmbeddedNulCheck>(
|
|
"misc-string-literal-with-embedded-nul");
|
|
CheckFactories.registerCheck<SuspiciousMissingCommaCheck>(
|
|
"misc-suspicious-missing-comma");
|
|
CheckFactories.registerCheck<SuspiciousSemicolonCheck>(
|
|
"misc-suspicious-semicolon");
|
|
CheckFactories.registerCheck<SwappedArgumentsCheck>(
|
|
"misc-swapped-arguments");
|
|
CheckFactories.registerCheck<ThrowByValueCatchByReferenceCheck>(
|
|
"misc-throw-by-value-catch-by-reference");
|
|
CheckFactories.registerCheck<UndelegatedConstructorCheck>(
|
|
"misc-undelegated-constructor");
|
|
CheckFactories.registerCheck<UniqueptrResetReleaseCheck>(
|
|
"misc-uniqueptr-reset-release");
|
|
CheckFactories.registerCheck<UnusedAliasDeclsCheck>(
|
|
"misc-unused-alias-decls");
|
|
CheckFactories.registerCheck<UnusedParametersCheck>(
|
|
"misc-unused-parameters");
|
|
CheckFactories.registerCheck<UnusedRAIICheck>("misc-unused-raii");
|
|
CheckFactories.registerCheck<VirtualNearMissCheck>(
|
|
"misc-virtual-near-miss");
|
|
}
|
|
};
|
|
|
|
} // namespace misc
|
|
|
|
// Register the MiscTidyModule using this statically initialized variable.
|
|
static ClangTidyModuleRegistry::Add<misc::MiscModule>
|
|
X("misc-module", "Adds miscellaneous lint checks.");
|
|
|
|
// This anchor is used to force the linker to link in the generated object file
|
|
// and thus register the MiscModule.
|
|
volatile int MiscModuleAnchorSource = 0;
|
|
|
|
} // namespace tidy
|
|
} // namespace clang
|