nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Switching getAttrs calls over to using a specific_attr_iterator. No functional changes intended.

Browse Source 
llvm-svn: 197681
This commit is contained in:
Aaron Ballman
2013-12-19 15:35:31 +00:00
parent 9d95e8d530
commit ee58e6d6d2
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
clang/lib/Analysis/ThreadSafety.cpp
View File

@@ -1900,10 +1900,10 @@ void BuildLockset::checkAccess(const Expr *Exp, AccessKind AK) {
Analyzer->Handler.handleNoMutexHeld(D, POK_VarAccess, AK,
Exp->getExprLoc());
const AttrVec &ArgAttrs = D->getAttrs();
for (unsigned i = 0, Size = ArgAttrs.size(); i < Size; ++i)
if (GuardedByAttr *GBAttr = dyn_cast<GuardedByAttr>(ArgAttrs[i]))
warnIfMutexNotHeld(D, Exp, AK, GBAttr->getArg(), POK_VarAccess);
for (specific_attr_iterator<GuardedByAttr>
I = D->specific_attr_begin<GuardedByAttr>(),
E = D->specific_attr_end<GuardedByAttr>(); I != E; ++I)
warnIfMutexNotHeld(D, Exp, AK, (*I)->getArg(), POK_VarAccess);
}
/// \brief Checks pt_guarded_by and pt_guarded_var attributes.
@@ -1938,10 +1938,10 @@ void BuildLockset::checkPtAccess(const Expr *Exp, AccessKind AK) {
Analyzer->Handler.handleNoMutexHeld(D, POK_VarDereference, AK,
Exp->getExprLoc());
const AttrVec &ArgAttrs = D->getAttrs();
for (unsigned i = 0, Size = ArgAttrs.size(); i < Size; ++i)
if (PtGuardedByAttr *GBAttr = dyn_cast<PtGuardedByAttr>(ArgAttrs[i]))
warnIfMutexNotHeld(D, Exp, AK, GBAttr->getArg(), POK_VarDereference);
for (specific_attr_iterator<PtGuardedByAttr>
I = D->specific_attr_begin<PtGuardedByAttr>(),
E = D->specific_attr_end<PtGuardedByAttr>(); I != E; ++I)
warnIfMutexNotHeld(D, Exp, AK, (*I)->getArg(), POK_VarDereference);
}