nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PR21706: -Wunsequenced was missing warnings when leaving a sequenced region that contained side effects.

Browse Source 
llvm-svn: 223184
This commit is contained in:
Richard Smith
2014-12-03 01:05:50 +00:00
parent 4a5697e659
commit e8efd99b24
2 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
clang/lib/Sema/SemaChecking.cpp
View File

@@ -7014,11 +7014,12 @@ class SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> {
Self.ModAsSideEffect = &ModAsSideEffect;
}
~SequencedSubexpression() {
for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) {
UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first];
U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second;
Self.addUsage(U, ModAsSideEffect[I].first,
ModAsSideEffect[I].second.Use, UK_ModAsValue);
for (auto MI = ModAsSideEffect.rbegin(), ME = ModAsSideEffect.rend();
MI != ME; ++MI) {
UsageInfo &U = Self.UsageMap[MI->first];
auto &SideEffectUsage = U.Uses[UK_ModAsSideEffect];
Self.addUsage(U, MI->first, SideEffectUsage.Use, UK_ModAsValue);
SideEffectUsage = MI->second;
}
Self.ModAsSideEffect = OldModAsSideEffect;
}