nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

<rdar://problem/10103468>

Browse Source 
I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had 
lldb_private::Section pointers into modules that had been removed or 
replaced. This also let to grabbing stale modules from those sections. 
So I needed to thread harded the Address, Section and related objects.

To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *. 

Address objects now have weak references to their sections which can
safely go stale when a module gets destructed. 

This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.

llvm-svn: 151336
This commit is contained in:
Greg Clayton
2012-02-24 01:59:29 +00:00
parent da97054114
commit e72dfb321c
90 changed files with 1357 additions and 1027 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/source/API/SBModule.cpp
View File

@@ -331,7 +331,7 @@ SBModule::GetSectionAtIndex (size_t idx)
SectionList *section_list = obj_file->GetSectionList ();
if (section_list)
sb_section.SetSection(section_list->GetSectionAtIndex (idx).get());
sb_section.SetSP(section_list->GetSectionAtIndex (idx));
}
}
return sb_section;
@@ -467,7 +467,7 @@ SBModule::FindSection (const char *sect_name)
SectionSP section_sp (section_list->FindSectionByName(const_sect_name));
if (section_sp)
{
sb_section.SetSection(section_sp.get());
sb_section.SetSP (section_sp);
}
}
}