nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't convert object_error's enum to and from int.

Browse Source 
This allows the compiler to see the enum and warn about it. While in here,
fix a switch to not use a default and fix style violations.

llvm-svn: 184186
This commit is contained in:
Rafael Espindola
2013-06-18 13:30:31 +00:00
parent fc3f61fcf0
commit e107ade3f9
2 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/lib/Object/Error.cpp
View File

@@ -31,7 +31,8 @@ const char *_object_error_category::name() const {
}
std::string _object_error_category::message(int ev) const {
switch (ev) {
object_error::Impl E = static_cast<object_error::Impl>(ev);
switch (E) {
case object_error::success: return "Success";
case object_error::invalid_file_type:
return "The file was not recognized as a valid object file";
@@ -39,10 +40,9 @@ std::string _object_error_category::message(int ev) const {
return "Invalid data was encountered while parsing the file";
case object_error::unexpected_eof:
return "The end of the file was unexpectedly encountered";
default:
llvm_unreachable("An enumerator of object_error does not have a message "
"defined.");
}
llvm_unreachable("An enumerator of object_error does not have a message "
"defined.");
}
error_condition _object_error_category::default_error_condition(int ev) const {