nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

llvm-readobj: relocAddressLess could potentially lie

Browse Source 
On error conditions, relocAddressLess might claim that a value is less
than itself.  Instead, abort llvm-readobj.  No functionality change
intended.

llvm-svn: 221872
This commit is contained in:
David Majnemer
2014-11-13 07:54:05 +00:00
parent 1e783024d3
commit e0eb086dd4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/tools/llvm-readobj/llvm-readobj.cpp
View File

@@ -168,8 +168,8 @@ bool error(std::error_code EC) {
bool relocAddressLess(RelocationRef a, RelocationRef b) {
uint64_t a_addr, b_addr;
if (error(a.getOffset(a_addr))) return false;
if (error(b.getOffset(b_addr))) return false;
if (error(a.getOffset(a_addr))) exit(ReturnValue);
if (error(b.getOffset(b_addr))) exit(ReturnValue);
return a_addr < b_addr;
}