nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PGO: Use the main file name to help distinguish functions with local linkage.

Browse Source 
In addition, for all functions, use the name from the llvm::Function to
identify the function in the profile data. Compute that "function name",
including the file name for local functions, once when assigning the PGO
counters and store it in the CodeGenPGO class.

Move the code to add InlineHint and Cold attributes out of StartFunction(),
because the "function name" string isn't available at that point.

llvm-svn: 203075
This commit is contained in:
Bob Wilson
2014-03-06 04:55:41 +00:00
parent d0b7824ece
commit da1ebedeea
5 changed files with 73 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
clang/lib/CodeGen/CodeGenFunction.cpp
View File

@@ -589,15 +589,6 @@ void CodeGenFunction::StartFunction(GlobalDecl GD,
if (CGM.getCodeGenOpts().InstrumentForProfiling)
EmitMCountInstrumentation();
if (CGM.getPGOData() && D) {
// Turn on InlineHint attribute for hot functions.
if (CGM.getPGOData()->isHotFunction(CGM.getMangledName(GD)))
Fn->addFnAttr(llvm::Attribute::InlineHint);
// Turn on Cold attribute for cold functions.
else if (CGM.getPGOData()->isColdFunction(CGM.getMangledName(GD)))
Fn->addFnAttr(llvm::Attribute::Cold);
}
if (RetTy->isVoidType()) {
// Void type; nothing to return.
ReturnValue = 0;
@@ -770,7 +761,7 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD, llvm::Function *Fn,
StartFunction(GD, ResTy, Fn, FnInfo, Args, BodyRange.getBegin());
// Generate the body of the function.
PGO.assignRegionCounters(GD.getDecl(), CGM.getMangledName(GD));
PGO.assignRegionCounters(GD.getDecl(), CurFn);
if (isa<CXXDestructorDecl>(FD))
EmitDestructorBody(Args);
else if (isa<CXXConstructorDecl>(FD))
@@ -831,7 +822,7 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD, llvm::Function *Fn,
if (!CurFn->doesNotThrow())
TryMarkNoThrow(CurFn);
PGO.emitWriteoutFunction(CGM.getMangledName(CurGD));
PGO.emitWriteoutFunction();
PGO.destroyRegionCounters();
}