nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Delete UnknownAddress. It is a perfectly valid symbol value.

Browse Source 
getSymbolValue now returns a value that in convenient for most callers:
* 0 for undefined
* symbol size for common symbols
* offset/address for symbols the rest

Code that needs something more specific can check getSymbolFlags.

llvm-svn: 241605
This commit is contained in:
Rafael Espindola
2015-07-07 17:12:59 +00:00
parent 76413ecb60
commit be8b0ea854
15 changed files with 41 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Object/COFFObjectFile.cpp
View File

@@ -154,13 +154,8 @@ ErrorOr<StringRef> COFFObjectFile::getSymbolName(DataRefImpl Ref) const {
return Result;
}
uint64_t COFFObjectFile::getSymbolValue(DataRefImpl Ref) const {
COFFSymbolRef Sym = getCOFFSymbol(Ref);
if (Sym.isAnyUndefined() || Sym.isCommon())
return UnknownAddress;
return Sym.getValue();
uint64_t COFFObjectFile::getSymbolValueImpl(DataRefImpl Ref) const {
return getCOFFSymbol(Ref).getValue();
}
ErrorOr<uint64_t> COFFObjectFile::getSymbolAddress(DataRefImpl Ref) const {