nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[llvm-cov] Improve error messages

Browse Source 
While we're at it, extend an existing test to make sure that error
messages look reasonable.

llvm-svn: 275520
This commit is contained in:
Vedant Kumar
2016-07-15 01:53:39 +00:00
parent fa0f2a0dcf
commit b95dc4608d
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/tools/llvm-cov/CodeCoverage.cpp
View File

@@ -117,7 +117,7 @@ static std::string getErrorString(const Twine &Message, StringRef Whence,
std::string Str = (Warning ? "warning" : "error");
Str += ": ";
if (!Whence.empty())
Str += Whence;
Str += Whence.str() + ": ";
Str += Message.str() + "\n";
return Str;
}
@@ -504,7 +504,7 @@ int CodeCoverageTool::show(int argc, const char **argv,
if (!Filters.empty()) {
auto OSOrErr = Printer->createViewFile("functions", /*InToplevel=*/true);
if (Error E = OSOrErr.takeError()) {
error(toString(std::move(E)));
error("Could not create view file!", toString(std::move(E)));
return 1;
}
auto OS = std::move(OSOrErr.get());
@@ -540,7 +540,7 @@ int CodeCoverageTool::show(int argc, const char **argv,
// Create an index out of the source files.
if (ViewOpts.hasOutputDirectory()) {
if (Error E = Printer->createIndexFile(SourceFiles)) {
error(toString(std::move(E)));
error("Could not create index file!", toString(std::move(E)));
return 1;
}
}
@@ -561,7 +561,7 @@ int CodeCoverageTool::show(int argc, const char **argv,
auto OSOrErr = Printer->createViewFile(SourceFile, /*InToplevel=*/false);
if (Error E = OSOrErr.takeError()) {
deferError(toString(std::move(E)));
deferError("Could not create view file!", toString(std::move(E)));
return;
}
auto OS = std::move(OSOrErr.get());