nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Driver: Use pointee_iterator rather than iterating over unique_ptrs

Browse Source 
There's probably never a good reason to iterate over unique_ptrs. This
lets us use range-for and say Job.foo instead of (*it)->foo in a few
places.

llvm-svn: 218938
This commit is contained in:
Justin Bogner
2014-10-03 01:04:53 +00:00
parent e83f59e658
commit aab9792b6c
7 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
clang/lib/Tooling/CompilationDatabase.cpp
View File

@@ -249,10 +249,9 @@ static bool stripPositionalArgs(std::vector<const char *> Args,
CompileJobAnalyzer CompileAnalyzer;
for (driver::JobList::const_iterator I = Jobs.begin(), E = Jobs.end(); I != E;
++I) {
if ((*I)->getKind() == driver::Job::CommandClass) {
const driver::Command &Cmd = cast<driver::Command>(**I);
for (const auto &Job : Jobs) {
if (Job.getKind() == driver::Job::CommandClass) {
const driver::Command &Cmd = cast<driver::Command>(Job);
// Collect only for Assemble jobs. If we do all jobs we get duplicates
// since Link jobs point to Assemble jobs as inputs.
if (Cmd.getSource().getKind() == driver::Action::AssembleJobClass)