[memprof] Remove the "Live on exit:" print for text format.

We dropped the printing of live on exit blocks in rG1243cef245f6 -
the commit changed the insertOrMerge logic. Remove the message since it
is no longer needed (all live blocks are inserted into the hashmap)
before serializing/printing the profile. Furthermore, the original
intent was to capture evicted blocks so it wasn't entirely correct.

Also update the binary format test invocation to remove the redundant
print_text directive now that it is the default.

Differential Revision: https://reviews.llvm.org/D114285
This commit is contained in:
Snehasish Kumar
2021-11-19 13:13:02 -08:00
parent 98daa4e425
commit a4b92d6158
2 changed files with 8 additions and 5 deletions

View File

@@ -252,6 +252,8 @@ struct Allocator {
InsertLiveBlocks();
if (print_text) {
if (!flags()->print_terse)
Printf("Recorded MIBs (incl. live on exit):\n");
MIBMap.ForEach(PrintCallback,
reinterpret_cast<void *>(flags()->print_terse));
StackDepotPrintAll();
@@ -271,9 +273,6 @@ struct Allocator {
// Inserts any blocks which have been allocated but not yet deallocated.
void InsertLiveBlocks() {
if (print_text && !flags()->print_terse)
Printf("Live on exit:\n");
allocator.ForEachChunk(
[](uptr chunk, void *alloc) {
u64 user_requested_size;