nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix handling of C99 "extern inline" semantics when dealing with

Browse Source 
multiple declarations of the function. Should fix PR3989 and
<rdar://problem/6818429>.

llvm-svn: 69905
This commit is contained in:
Douglas Gregor
2009-04-23 18:22:55 +00:00
parent a6acb390e7
commit 89c8e000cf
7 changed files with 93 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
clang/lib/CodeGen/CodeGenModule.cpp
View File

@@ -242,7 +242,7 @@ GetLinkageForFunction(const FunctionDecl *FD, const LangOptions &Features) {
// this is C89 mode, we use to GNU semantics.
if (FD->hasAttr<GNUInlineAttr>() || (!Features.C99 && !Features.CPlusPlus)) {
// extern inline in GNU mode is like C99 inline.
if (FD->getStorageClass() == FunctionDecl::Extern)
if (FD->isC99InlineDefinition())
return CodeGenModule::GVA_C99Inline;
// Normal inline is a strong symbol.
return CodeGenModule::GVA_StrongExternal;
@@ -254,11 +254,10 @@ GetLinkageForFunction(const FunctionDecl *FD, const LangOptions &Features) {
return CodeGenModule::GVA_CXXInline;
assert(Features.C99 && "Must be in C99 mode if not in C89 or C++ mode");
// extern inline in C99 is a strong definition.
if (FD->getStorageClass() == FunctionDecl::Extern)
return CodeGenModule::GVA_StrongExternal;
return CodeGenModule::GVA_C99Inline;
if (FD->isC99InlineDefinition())
return CodeGenModule::GVA_C99Inline;
return CodeGenModule::GVA_StrongExternal;
}
/// SetFunctionDefinitionAttributes - Set attributes for a global.