nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make conversion specifier warning refer to typedef if possible.

Browse Source 
For example, the warning for printf("%zu", 42.0);
changes from "conversion specifies type 'unsigned long'" to "conversion
specifies type 'size_t' (aka 'unsigned long')"

llvm-svn: 145697
This commit is contained in:
Hans Wennborg
2011-12-02 19:22:15 +00:00
parent 541392832f
commit 70f7213d2c
5 changed files with 74 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
clang/lib/Analysis/FormatString.cpp
View File

@@ -230,7 +230,8 @@ bool ArgTypeResult::matchesType(ASTContext &C, QualType argTy) const {
case SpecificTy: {
argTy = C.getCanonicalType(argTy).getUnqualifiedType();
if (T == argTy)
QualType U = C.getCanonicalType(T);
if (U == argTy)
return true;
// Check for "compatible types".
if (const BuiltinType *BT = argTy->getAs<BuiltinType>())
@@ -239,26 +240,26 @@ bool ArgTypeResult::matchesType(ASTContext &C, QualType argTy) const {
break;
case BuiltinType::Char_S:
case BuiltinType::SChar:
return T == C.UnsignedCharTy;
return U == C.UnsignedCharTy;
case BuiltinType::Char_U:
case BuiltinType::UChar:
return T == C.SignedCharTy;
return U == C.SignedCharTy;
case BuiltinType::Short:
return T == C.UnsignedShortTy;
return U == C.UnsignedShortTy;
case BuiltinType::UShort:
return T == C.ShortTy;
return U == C.ShortTy;
case BuiltinType::Int:
return T == C.UnsignedIntTy;
return U == C.UnsignedIntTy;
case BuiltinType::UInt:
return T == C.IntTy;
return U == C.IntTy;
case BuiltinType::Long:
return T == C.UnsignedLongTy;
return U == C.UnsignedLongTy;
case BuiltinType::ULong:
return T == C.LongTy;
return U == C.LongTy;
case BuiltinType::LongLong:
return T == C.UnsignedLongLongTy;
return U == C.UnsignedLongLongTy;
case BuiltinType::ULongLong:
return T == C.LongLongTy;
return U == C.LongLongTy;
}
return false;
}
@@ -485,5 +486,3 @@ bool FormatSpecifier::hasValidLengthModifier() const {
}
return false;
}