nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ThinLTO] Address post-review suggestions for index-based WPD summary

Browse Source 
Removes a couple of unnecessary and/or redundant checks introduced by
r364960.

llvm-svn: 364968
This commit is contained in:
Teresa Johnson
2019-07-02 21:07:45 +00:00
parent 48fe0fe884
commit 5b868285ba
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
View File

@@ -3688,20 +3688,19 @@ void ModuleBitcodeWriterBase::writeModuleLevelReferences(
// been initialized from a DenseSet.
llvm::sort(NameVals.begin() + SizeBeforeRefs, NameVals.end());
if (!VTableFuncs.empty()) {
if (VTableFuncs.empty())
Stream.EmitRecord(bitc::FS_PERMODULE_GLOBALVAR_INIT_REFS, NameVals,
FSModRefsAbbrev);
else {
// VTableFuncs pairs should already be sorted by offset.
for (auto &P : VTableFuncs) {
NameVals.push_back(VE.getValueID(P.FuncVI.getValue()));
NameVals.push_back(P.VTableOffset);
}
}
if (VTableFuncs.empty())
Stream.EmitRecord(bitc::FS_PERMODULE_GLOBALVAR_INIT_REFS, NameVals,
FSModRefsAbbrev);
else
Stream.EmitRecord(bitc::FS_PERMODULE_VTABLE_GLOBALVAR_INIT_REFS, NameVals,
FSModVTableRefsAbbrev);
}
NameVals.clear();
}
@@ -3854,14 +3853,12 @@ void ModuleBitcodeWriterBase::writePerModuleGlobalValueSummary() {
NameVals.clear();
}
if (!Index->typeIdCompatibleVtableMap().empty()) {
for (auto &S : Index->typeIdCompatibleVtableMap()) {
writeTypeIdCompatibleVtableSummaryRecord(NameVals, StrtabBuilder, S.first,
S.second, VE);
Stream.EmitRecord(bitc::FS_TYPE_ID_METADATA, NameVals,
TypeIdCompatibleVtableAbbrev);
NameVals.clear();
}
for (auto &S : Index->typeIdCompatibleVtableMap()) {
writeTypeIdCompatibleVtableSummaryRecord(NameVals, StrtabBuilder, S.first,
S.second, VE);
Stream.EmitRecord(bitc::FS_TYPE_ID_METADATA, NameVals,
TypeIdCompatibleVtableAbbrev);
NameVals.clear();
}
Stream.ExitBlock();