nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Converted AST Pretty-Printer to use iostreams instead of FILE*. This fixes

Browse Source 
a bug where the statement pretty-printer used iostreams but the AST printer
did not.  This was an issue when dumping ASTs to something other than stderr.

Updated SerializationTest to use the new iostreams interface for the AST printer.

llvm-svn: 44417
This commit is contained in:
Ted Kremenek
2007-11-28 21:32:21 +00:00
parent 5d169cf285
commit 5933768bec
3 changed files with 120 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
clang/Driver/SerializationTest.cpp
View File

@@ -23,11 +23,11 @@
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Bitcode/Serialize.h"
#include "llvm/Bitcode/Deserialize.h"
#include <fstream>
#include <stdio.h>
#include <list>
using namespace clang;
using llvm::sys::TimeValue;
//===----------------------------------------------------------------------===//
// Utility classes
@@ -43,20 +43,6 @@ public:
operator T*() const { return Obj; }
T* operator->() { return Obj; }
};
class FileSP {
FILE* f;
public:
FileSP(const llvm::sys::Path& fname, const char* mode = "wb")
: f(fopen(fname.c_str(),mode)) {}
~FileSP() { if (f) fclose(f); }
operator FILE*() const { return f; }
private:
void operator=(const FileSP& RHS) {}
FileSP(const FileSP& RHS) {}
};
//===----------------------------------------------------------------------===//
// Driver code.
@@ -134,9 +120,9 @@ void SerializationTest::Serialize(llvm::sys::Path& Filename,
{ // Create a printer to "consume" our deserialized ASTS.
Janitor<ASTConsumer> Printer(CreateASTPrinter());
FileSP DeclFP(FNameDeclPrint,"w");
assert (DeclFP && "Could not open file for printing out decls.");
Janitor<ASTConsumer> FilePrinter(CreateASTPrinter(DeclFP));
std::ofstream DeclPP(FNameDeclPrint.c_str());
assert (DeclPP && "Could not open file for printing out decls.");
Janitor<ASTConsumer> FilePrinter(CreateASTPrinter(&DeclPP));
for (std::list<Decl*>::iterator I=Decls.begin(), E=Decls.end(); I!=E; ++I) {
llvm::cerr << "Serializing: Decl.\n";
@@ -183,15 +169,13 @@ void SerializationTest::Serialize(llvm::sys::Path& Filename,
// ===---------------------------------------------------===/
// Finalize serialization: write the bits to disk.
{
FileSP fp(Filename);
if (fp)
fwrite((char*)&Buffer.front(), sizeof(char), Buffer.size(), fp);
else {
llvm::cerr << "Error: Cannot open " << Filename.c_str() << "\n";
return;
}
if (FILE* fp = fopen(Filename.c_str(),"wb")) {
fwrite((char*)&Buffer.front(), sizeof(char), Buffer.size(), fp);
fclose(fp);
}
else {
llvm::cerr << "Error: Cannot open " << Filename.c_str() << "\n";
return;
}
llvm::cerr << "Commited bitstream to disk: " << Filename.c_str() << "\n";
@@ -280,9 +264,9 @@ void SerializationTest::Deserialize(llvm::sys::Path& Filename,
// Create a printer to "consume" our deserialized ASTS.
ASTConsumer* Printer = CreateASTPrinter();
Janitor<ASTConsumer> PrinterJanitor(Printer);
FileSP DeclFP(FNameDeclPrint,"w");
assert (DeclFP && "Could not open file for printing out decls.");
Janitor<ASTConsumer> FilePrinter(CreateASTPrinter(DeclFP));
std::ofstream DeclPP(FNameDeclPrint.c_str());
assert (DeclPP && "Could not open file for printing out decls.");
Janitor<ASTConsumer> FilePrinter(CreateASTPrinter(&DeclPP));
// The remaining objects in the file are top-level decls.
while (!Dezr.FinishedBlock(DeclBlockLoc)) {