nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BitcodeWriter: Stop using implicit ilist iterator conversion, NFC

Browse Source 
Now LLVMBitWriter compiles without implicit ilist iterator conversions.

In these cases, the cleanest thing was to switch to range-based for
loops.  Since there wasn't much noise I converted sub-loops and parent
loops as a drive-by.

llvm-svn: 250144
This commit is contained in:
Duncan P. N. Exon Smith
2015-10-13 03:26:19 +00:00
parent 1ed6910338
commit 584af871cc
2 changed files with 23 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
View File

@@ -1350,16 +1350,15 @@ static void WriteMetadataAttachment(const Function &F,
Record.clear();
}
for (Function::const_iterator BB = F.begin(), E = F.end(); BB != E; ++BB)
for (BasicBlock::const_iterator I = BB->begin(), E = BB->end();
I != E; ++I) {
for (const BasicBlock &BB : F)
for (const Instruction &I : BB) {
MDs.clear();
I->getAllMetadataOtherThanDebugLoc(MDs);
I.getAllMetadataOtherThanDebugLoc(MDs);
// If no metadata, ignore instruction.
if (MDs.empty()) continue;
Record.push_back(VE.getInstructionID(I));
Record.push_back(VE.getInstructionID(&I));
for (unsigned i = 0, e = MDs.size(); i != e; ++i) {
Record.push_back(MDs[i].first);