nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable the available_externally optimization for inline virtual

Browse Source 
methods for which the key function is guaranteed to be in another
translation unit. Unfortunately, this guarantee isn't the case when
dealing with shared libraries that fail to export these virtual method
definitions. 

I'm reopening PR6747 so we can consider this again at a later point in
time.

llvm-svn: 103741
This commit is contained in:
Douglas Gregor
2010-05-13 21:36:56 +00:00
parent d74a564feb
commit 500d9f8221
2 changed files with 0 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
clang/lib/CodeGen/CodeGenModule.cpp
View File

@@ -316,17 +316,6 @@ GetLinkageForFunction(ASTContext &Context, const FunctionDecl *FD,
== TSK_ExplicitInstantiationDeclaration)
return CodeGenModule::GVA_C99Inline;
// If this is a virtual method and its class has a key method in another
// translation unit, we know that this method will be present in that
// translation unit. In this translation unit we will use this method
// only for inlining and analysis. This is the semantics of c99 inline.
if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD)) {
const CXXRecordDecl *RD = MD->getParent();
if (MD->isVirtual() && !MD->isImplicit() &&
CodeGenVTables::isKeyFunctionInAnotherTU(Context, RD))
return CodeGenModule::GVA_C99Inline;
}
return CodeGenModule::GVA_CXXInline;
}