nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove some calls to std::move.

Browse Source 
Instead of moving out the data in a ErrorOr<std::unique_ptr<Foo>>, get
a reference to it.

Thanks to David Blaikie for the suggestion.

llvm-svn: 214516
This commit is contained in:
Rafael Espindola
2014-08-01 14:31:55 +00:00
parent 5d457dede9
commit 3f6481d0d3
19 changed files with 65 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/tools/llvm-objdump/llvm-objdump.cpp
View File

@@ -891,11 +891,11 @@ static void DumpInput(StringRef file) {
errs() << ToolName << ": '" << file << "': " << EC.message() << ".\n";
return;
}
std::unique_ptr<Binary> binary = std::move(BinaryOrErr.get());
Binary &Binary = *BinaryOrErr.get();
if (Archive *a = dyn_cast<Archive>(binary.get()))
if (Archive *a = dyn_cast<Archive>(&Binary))
DumpArchive(a);
else if (ObjectFile *o = dyn_cast<ObjectFile>(binary.get()))
else if (ObjectFile *o = dyn_cast<ObjectFile>(&Binary))
DumpObject(o);
else
errs() << ToolName << ": '" << file << "': " << "Unrecognized file type.\n";