nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CodeGen may see out-of-line declarations of the various special member

Browse Source 
functions when they are explicitly declared, e.g., via a function
template specialization or explicit template instantiation
declaration. Don't try to synthesize bodies for the special member
functions in this case; rather, check whether we have an implicit
declaration and, if so, synthesize the appropriate function
body. Fixes PR5084.

llvm-svn: 83212
This commit is contained in:
Douglas Gregor
2009-10-01 20:44:19 +00:00
parent b3c44f9ee9
commit 369acf9304
2 changed files with 32 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
clang/lib/CodeGen/CodeGenFunction.cpp
View File

@@ -239,28 +239,37 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD,
if (const CXXDestructorDecl *DD = dyn_cast<CXXDestructorDecl>(FD))
EmitDtorEpilogue(DD, GD.getDtorType());
FinishFunction(S->getRBracLoc());
}
else
} else if (FD->isImplicit()) {
const CXXRecordDecl *ClassDecl =
cast<CXXRecordDecl>(FD->getDeclContext());
(void) ClassDecl;
if (const CXXConstructorDecl *CD = dyn_cast<CXXConstructorDecl>(FD)) {
const CXXRecordDecl *ClassDecl =
cast<CXXRecordDecl>(CD->getDeclContext());
(void) ClassDecl;
// FIXME: For C++0x, we want to look for implicit *definitions* of
// these special member functions, rather than implicit *declarations*.
if (CD->isCopyConstructor(getContext())) {
assert(!ClassDecl->hasUserDeclaredCopyConstructor() &&
"bogus constructor is being synthesize");
"Cannot synthesize a non-implicit copy constructor");
SynthesizeCXXCopyConstructor(CD, GD.getCtorType(), Fn, Args);
}
else {
} else if (CD->isDefaultConstructor()) {
assert(!ClassDecl->hasUserDeclaredConstructor() &&
"bogus constructor is being synthesize");
"Cannot synthesize a non-implicit default constructor.");
SynthesizeDefaultConstructor(CD, GD.getCtorType(), Fn, Args);
} else {
assert(false && "Implicit constructor cannot be synthesized");
}
}
else if (const CXXDestructorDecl *CD = dyn_cast<CXXDestructorDecl>(FD))
SynthesizeDefaultDestructor(CD, GD.getDtorType(), Fn, Args);
else if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD)) {
if (MD->isCopyAssignment())
} else if (const CXXDestructorDecl *CD = dyn_cast<CXXDestructorDecl>(FD)) {
assert(!ClassDecl->hasUserDeclaredDestructor() &&
"Cannot synthesize a non-implicit destructor");
SynthesizeDefaultDestructor(CD, GD.getDtorType(), Fn, Args);
} else if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD)) {
assert(MD->isCopyAssignment() &&
!ClassDecl->hasUserDeclaredCopyAssignment() &&
"Cannot synthesize a method that is not an implicit-defined "
"copy constructor");
SynthesizeCXXCopyAssignment(MD, Fn, Args);
} else {
assert(false && "Cannot synthesize unknown implicit function");
}
}
// Destroy the 'this' declaration.