nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change the linker_private_weak_def_auto' linkage to linkonce_odr_auto_hide' to

Browse Source 
make it more consistent with its intended semantics.

The `linker_private_weak_def_auto' linkage type was meant to automatically hide
globals which never had their addresses taken. It has nothing to do with the
`linker_private' linkage type, which outputs the symbols with a `l' (ell) prefix
among other things.

The intended semantic is more like the `linkonce_odr' linkage type.

Change the name of the linkage type to `linkonce_odr_auto_hide'. And therefore
changing the semantics so that it produces the correct output for the linker.

Note: The old linkage name `linker_private_weak_def_auto' will still parse but
is not a synonym for `linkonce_odr_auto_hide'. This should be removed in 4.0.
<rdar://problem/11754934>

llvm-svn: 162114
This commit is contained in:
Bill Wendling
2012-08-17 18:33:14 +00:00
parent 9a16735e22
commit 34bc34ecae
17 changed files with 59 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Bitcode/Reader/BitcodeReader.cpp
View File

@@ -89,7 +89,7 @@ static GlobalValue::LinkageTypes GetDecodedLinkage(unsigned Val) {
case 12: return GlobalValue::AvailableExternallyLinkage;
case 13: return GlobalValue::LinkerPrivateLinkage;
case 14: return GlobalValue::LinkerPrivateWeakLinkage;
case 15: return GlobalValue::LinkerPrivateWeakDefAutoLinkage;
case 15: return GlobalValue::LinkOnceODRAutoHideLinkage;
}
}