nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[CodeGen] Make the TwoAddressInstructionPass check if the instruction is commutable before calling findCommutedOpIndices for every operand. Also make sure the operand is a register before each call to save some work on commutable instructions that might have an operand.

Browse Source 
llvm-svn: 281158
This commit is contained in:
Craig Topper
2016-09-11 06:00:15 +00:00
parent 3639cda748
commit 1f81deee1f
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/CodeGen/TwoAddressInstructionPass.cpp
View File

@@ -1171,6 +1171,9 @@ bool TwoAddressInstructionPass::tryInstructionCommute(MachineInstr *MI,
unsigned BaseOpIdx, unsigned BaseOpIdx,
bool BaseOpKilled, bool BaseOpKilled,
unsigned Dist) { unsigned Dist) {
if (!MI->isCommutable())
return false;
unsigned DstOpReg = MI->getOperand(DstOpIdx).getReg(); unsigned DstOpReg = MI->getOperand(DstOpIdx).getReg();
unsigned BaseOpReg = MI->getOperand(BaseOpIdx).getReg(); unsigned BaseOpReg = MI->getOperand(BaseOpIdx).getReg();
unsigned OpsNum = MI->getDesc().getNumOperands(); unsigned OpsNum = MI->getDesc().getNumOperands();
@@ -1180,7 +1183,7 @@ bool TwoAddressInstructionPass::tryInstructionCommute(MachineInstr *MI,
// and OtherOpIdx are commutable, it does not really search for // and OtherOpIdx are commutable, it does not really search for
// other commutable operands and does not change the values of passed // other commutable operands and does not change the values of passed
// variables. // variables.
if (OtherOpIdx == BaseOpIdx || if (OtherOpIdx == BaseOpIdx || !MI->getOperand(OtherOpIdx).isReg() ||
!TII->findCommutedOpIndices(*MI, BaseOpIdx, OtherOpIdx)) !TII->findCommutedOpIndices(*MI, BaseOpIdx, OtherOpIdx))
continue; continue;