nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In the ObjectFile interface, replace isInternal(), isAbsolute(), isGlobal(), and isWeak(), with a bitset of flags.

Browse Source 
llvm-svn: 151670
This commit is contained in:
David Meyer
2012-02-28 23:47:53 +00:00
parent fcbfdee5df
commit 1df4b84db4
9 changed files with 78 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
llvm/lib/Object/COFFObjectFile.cpp
View File

@@ -159,17 +159,23 @@ error_code COFFObjectFile::getSymbolType(DataRefImpl Symb,
return object_error::success;
}
error_code COFFObjectFile::isSymbolGlobal(DataRefImpl Symb,
bool &Result) const {
error_code COFFObjectFile::getSymbolFlags(DataRefImpl Symb,
uint32_t &Result) const {
const coff_symbol *symb = toSymb(Symb);
Result = (symb->StorageClass == COFF::IMAGE_SYM_CLASS_EXTERNAL);
return object_error::success;
}
Result = SymbolRef::SF_None;
// TODO: Set SF_FormatSpecific.
// TODO: This are certainly too restrictive.
if (symb->StorageClass == COFF::IMAGE_SYM_CLASS_EXTERNAL)
Result |= SymbolRef::SF_Global;
if (symb->StorageClass == COFF::IMAGE_SYM_CLASS_WEAK_EXTERNAL)
Result |= SymbolRef::SF_Weak;
if (symb->SectionNumber == COFF::IMAGE_SYM_ABSOLUTE)
Result |= SymbolRef::SF_Absolute;
error_code COFFObjectFile::isSymbolWeak(DataRefImpl Symb,
bool &Result) const {
const coff_symbol *symb = toSymb(Symb);
Result = (symb->StorageClass == COFF::IMAGE_SYM_CLASS_WEAK_EXTERNAL);
return object_error::success;
}
@@ -262,19 +268,6 @@ error_code COFFObjectFile::getSymbolNMTypeChar(DataRefImpl Symb,
return object_error::success;
}
error_code COFFObjectFile::isSymbolInternal(DataRefImpl Symb,
bool &Result) const {
Result = false;
return object_error::success;
}
error_code COFFObjectFile::isSymbolAbsolute(DataRefImpl Symb,
bool &Result) const {
const coff_symbol *symb = toSymb(Symb);
Result = symb->SectionNumber == COFF::IMAGE_SYM_ABSOLUTE;
return object_error::success;
}
error_code COFFObjectFile::getSymbolSection(DataRefImpl Symb,
section_iterator &Result) const {
const coff_symbol *symb = toSymb(Symb);