Fix crash in EmitDeclMetadata mode
Summary: This fixes a bug that's easily encountered in LLDB (https://llvm.org/bugs/show_bug.cgi?id=22875). The problem here is that we mangle a name during debug info emission, but never actually emit the actual Decl, so we run into problems in EmitDeclMetadata (which assumes such a Decl exists). Fix that by just skipping metadata emissions for mangled names that don't have associated Decls. Reviewers: rjmccall Subscribers: labath, cfe-commits Differential Revision: http://reviews.llvm.org/D13959 llvm-svn: 252229
This commit is contained in:
@@ -3707,10 +3707,12 @@ bool CodeGenModule::lookupRepresentativeDecl(StringRef MangledName,
|
||||
void CodeGenModule::EmitDeclMetadata() {
|
||||
llvm::NamedMDNode *GlobalMetadata = nullptr;
|
||||
|
||||
// StaticLocalDeclMap
|
||||
for (auto &I : MangledDeclNames) {
|
||||
llvm::GlobalValue *Addr = getModule().getNamedValue(I.second);
|
||||
EmitGlobalDeclMetadata(*this, GlobalMetadata, I.first, Addr);
|
||||
// Some mangled names don't necessarily have an associated GlobalValue
|
||||
// in this module, e.g. if we mangled it for DebugInfo.
|
||||
if (Addr)
|
||||
EmitGlobalDeclMetadata(*this, GlobalMetadata, I.first, Addr);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user