Synchronize globally-cached code completion results with the results

provided when the optimization is disabled. In particular, split
the completion context CCC_Other into two contexts: CCC_Other, which
means that it's an undisclosed context for which any other results are
unwelcome, and CCC_Recovery, which is used in recovery cases.

Since we're now using the completion context within the completion
results builder, make sure that it's always set to something.

Fixes <rdar://problem/8470644>.

llvm-svn: 114704

clang/lib/Sema/CodeCompleteConsumer.cpp

@@ -33,7 +33,7 @@ using llvm::StringRef;
 
 bool CodeCompletionContext::wantConstructorResults() const {
   switch (Kind) {
-  case CCC_Other:
+  case CCC_Recovery:
   case CCC_Statement:
   case CCC_Expression:
   case CCC_ObjCMessageReceiver:
@@ -61,6 +61,7 @@ bool CodeCompletionContext::wantConstructorResults() const {
   case CCC_NaturalLanguage:
   case CCC_SelectorName:
   case CCC_TypeQualifiers:
+  case CCC_Other:
     return false;
   }