nicolas/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a use-after-free bug I recently introduced in lookupModuleFile

Browse Source 
llvm-svn: 207932
This commit is contained in:
Ben Langmuir
2014-05-04 05:20:54 +00:00
parent 1b1256a1b1
commit 027731d7b5
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
clang/lib/Serialization/ModuleManager.cpp
View File

@@ -390,11 +390,10 @@ bool ModuleManager::lookupModuleFile(StringRef FileName,
}
if ((ExpectedSize && ExpectedSize != File->getSize()) ||
(ExpectedModTime && ExpectedModTime != File->getModificationTime())) {
FileMgr.invalidateCache(File);
File = nullptr;
(ExpectedModTime && ExpectedModTime != File->getModificationTime()))
// Do not destroy File, as it may be referenced. If we need to rebuild it,
// it will be destroyed by removeModules.
return true;
}
return false;
}