mirrors/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-12-05 01:10:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #29717 from overleaf/ii-subscpriptions-v1-id-index-history-v1

Browse Source 
[web] Fix failing acceptance tests in history-v1 and github-sync

GitOrigin-RevId: cae820598dfe7779386958fd759d3381b6007303
This commit is contained in:
Brian Gough
2025-11-17 18:43:54 +00:00
committed by Copybot
parent 341b9b9e0b
commit b7015c1dfa
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tools/migrations/20251030110238_update_subscription_v1_id_index.mjs
View File

@@ -17,6 +17,13 @@ const newIndexes = [
sparse: true,
},
]
const tempIndex = [
{
key: { v1_id: 1 },
name: 'v1_id_temp_migration',
sparse: false, // Non-sparse so it includes null/missing values
},
]
async function removeNullV1Ids(collection) {
// Remove the v1_id field from documents where it's null
@@ -64,14 +71,21 @@ async function assertNoDuplicateV1Ids(collection) {
const migrate = async client => {
const { db } = client
// Create temporary non-sparse index to allow queries with notablescan enabled
await Helpers.addIndexesToCollection(db.subscriptions, tempIndex)
// pre‑check (keep old index intact if failing)
await assertNoDuplicateV1Ids(db.subscriptions)
await removeNullV1Ids(db.subscriptions)
try {
await assertNoDuplicateV1Ids(db.subscriptions)
await removeNullV1Ids(db.subscriptions)
} catch (error) {
await Helpers.dropIndexesFromCollection(tempIndex)
throw error
}
await Helpers.addIndexesToCollection(db.subscriptions, newIndexes)
await Helpers.dropIndexesFromCollection(
db.subscriptions,
// drop the 20251010082205 index too which wasn't working properly
originalIndexes.concat({ name: 'v1_id_2' })
originalIndexes.concat({ name: 'v1_id_2' }).concat(tempIndex)
)
}