From 73b01a975ac2dff07a358fc2a85f0eaef4c4b369 Mon Sep 17 00:00:00 2001 From: Rocco Corsi <5201151+rcorsi@users.noreply.github.com> Date: Fri, 24 Oct 2025 22:06:53 -0400 Subject: [PATCH] CI: Add All_Debug CI job --- .github/workflows/ci.yml | 7 +++++++ .github/workflows/lagom-template.yml | 4 ++-- CMakePresets.json | 12 ++++++++++++ Meta/ladybird.py | 1 + 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 87b5d749e9e..6138bcde562 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -44,6 +44,13 @@ jobs: clang_plugins: false runner_labels: '["blacksmith-16vcpu-ubuntu-2404"]' + - os_name: 'Linux' + arch: 'x86_64' + build_preset: 'All_Debug' + toolchain: 'Clang' + clang_plugins: false + runner_labels: '["blacksmith-16vcpu-ubuntu-2404"]' + secrets: inherit uses: ./.github/workflows/lagom-template.yml with: diff --git a/.github/workflows/lagom-template.yml b/.github/workflows/lagom-template.yml index 09af14ad1f3..25f806c5cb7 100644 --- a/.github/workflows/lagom-template.yml +++ b/.github/workflows/lagom-template.yml @@ -203,14 +203,14 @@ jobs: UBSAN_OPTIONS: 'log_path="${{ github.workspace }}/ubsan.log"' - name: Test - if: ${{ inputs.build_preset != 'Fuzzers' && !contains(inputs.build_preset, 'Sanitizer') }} + if: ${{ inputs.build_preset != 'Fuzzers' && inputs.build_preset != 'All_Debug' && !contains(inputs.build_preset, 'Sanitizer') }} working-directory: ${{ github.workspace }} run: ctest --output-on-failure --test-dir Build --timeout 1800 env: TESTS_ONLY: 1 - name: Upload LibWeb Test Artifacts - if: ${{ always() && inputs.build_preset != 'Fuzzers' }} + if: ${{ always() && inputs.build_preset != 'Fuzzers' && inputs.build_preset != 'All_Debug' }} uses: actions/upload-artifact@v4 with: name: libweb-test-artifacts-${{ inputs.os_name }}-${{ inputs.build_preset }}-${{ inputs.toolchain }}-${{ inputs.clang-plugins }} diff --git a/CMakePresets.json b/CMakePresets.json index f23c9794c05..1cbbb122262 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -82,6 +82,18 @@ "VCPKG_OVERLAY_TRIPLETS": "${fileDir}/Meta/CMake/vcpkg/debug-triplets" } }, + { + "name": "All_Debug", + "inherits": "unix_base", + "displayName": "All Debug Config", + "description": "All Debug Unix build", + "binaryDir": "${fileDir}/Build/alldebug", + "cacheVariables": { + "CMAKE_BUILD_TYPE": "Debug", + "VCPKG_OVERLAY_TRIPLETS": "${fileDir}/Meta/CMake/vcpkg/debug-triplets", + "ENABLE_ALL_THE_DEBUG_MACROS": "ON" + } + }, { "name": "Windows_Experimental", "inherits": "windows_base", diff --git a/Meta/ladybird.py b/Meta/ladybird.py index 184b38e1198..bf262c853d2 100755 --- a/Meta/ladybird.py +++ b/Meta/ladybird.py @@ -271,6 +271,7 @@ def configure_build_env(platform: Platform, preset: str) -> tuple[Path, Path]: known_presets = { "Debug": build_root_dir / "debug", + "All_Debug": build_root_dir / "alldebug", "Distribution": build_root_dir / "distribution", "Release": build_root_dir / "release", "Sanitizer": build_root_dir / "sanitizers",